-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for 20741. Allow older versions of tools to pass null args. #20799
Conversation
c591da4
to
d6adf49
Compare
|
||
_reporter = reporter; | ||
_assembly = assembly; | ||
_projectDir = projectDir; | ||
_rootNamespace = rootNamespace; | ||
_language = language; | ||
_args = args; | ||
_args = args ?? Array.Empty<string>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could also just do this once in OperationExecutor's constructor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(And leave the assert's in these classes)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bricelam This is already checked in. Do you think these changes are important enough for a new PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Meh. We're not likely to add any new operations classes anytime soon.
Fixes #20741
Allow older versions of tools to pass null args. This should fix @ajcvickers comment. There may still be underlying issues with
MigrationsModelDiffer
.