Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query: MakeUnary/Binary should return null if invalid operator type #20847

Merged
merged 1 commit into from
May 6, 2020
Merged

Query: MakeUnary/Binary should return null if invalid operator type #20847

merged 1 commit into from
May 6, 2020

Conversation

smitpatel
Copy link
Member

Resolves #20622

@smitpatel smitpatel requested a review from a team May 5, 2020 19:29
roji
roji reviewed May 5, 2020
View reviewed changes
Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sometimes things take time 😄 #16562

src/EFCore.Relational/Query/SqlExpressionFactory.cs Show resolved Hide resolved
src/EFCore.Relational/Query/SqlExpressions/SqlBinaryExpression.cs Show resolved Hide resolved
@smitpatel smitpatel merged commit 59ae9ae into master May 6, 2020
@smitpatel smitpatel deleted the smit/supportedoperators branch May 6, 2020 05:52
@jaredpar jaredpar mentioned this pull request May 6, 2020
Closed
@ajcvickers ajcvickers mentioned this pull request May 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roji roji roji approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Query: Return null from SqlExpression.MakeBinary if operator type is not supported
2 participants
@smitpatel @roji