Add ConfigureAwait(false) #21110
Merged
Add ConfigureAwait(false) #21110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set up Microsoft.CodeAnalysis.FxCopAnalyzers with only the ConfigureAwait rule enabled. Closes #10164
|
This can actually be a breaking change, if the users are relying on their synchronization context to flow through. |
roji
added a commit
that referenced
this pull request
Jun 9, 2020
roji
added a commit
that referenced
this pull request
Jun 9, 2020
wtgodbe
pushed a commit
that referenced
this pull request
Jun 9, 2020
* [release/5.0-preview6] Update dependencies from dotnet/arcade (#21111) * Update dependencies from https://github.com/dotnet/arcade build 20200530.1 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 5.0.0-beta.20261.9 -> To Version 5.0.0-beta.20280.1 * [master] Update dependencies from dotnet/arcade (#21091) * Update dependencies from https://github.com/dotnet/arcade build 20200528.4 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 5.0.0-beta.20261.9 -> To Version 5.0.0-beta.20278.4 * Update dotnet on helix Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Brennan <brecon@microsoft.com> Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Brennan <brecon@microsoft.com> * Return ValueTask in loggers and interceptors (#21152) (#21158) Closes #21109 (cherry picked from commit 9f316e5) * Add ConfigureAwait(false) (#21110) (#21185) Set up Microsoft.CodeAnalysis.FxCopAnalyzers with only the ConfigureAwait rule enabled. Closes #10164 (cherry picked from commit e1c9a3a) Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Brennan <brecon@microsoft.com> Co-authored-by: Shay Rojansky <roji@roji.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set up Microsoft.CodeAnalysis.FxCopAnalyzers with only the ConfigureAwait rule enabled.
Closes #10164