Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inference issues around convert to object #21125

Merged
merged 6 commits into from
Jun 13, 2020
Merged

Fix inference issues around convert to object #21125

merged 6 commits into from
Jun 13, 2020

Commits on Jun 12, 2020

  1. Fix inference issues around convert to object 

    Fixes #19688
    @roji
    roji committed Jun 12, 2020
    Configuration menu
    Copy the full SHA
    f1357da View commit details
    Browse the repository at this point in the history

  2. Reimplement in VisitBinary

    @roji
    roji committed Jun 12, 2020
    Configuration menu
    Copy the full SHA
    2e3a0e2 View commit details
    Browse the repository at this point in the history

  3. Address review

    @roji
    roji committed Jun 12, 2020
    Configuration menu
    Copy the full SHA
    f2a82e3 View commit details
    Browse the repository at this point in the history

  4. Extract checks

    @roji
    roji committed Jun 12, 2020
    Configuration menu
    Copy the full SHA
    4386a20 View commit details
    Browse the repository at this point in the history

  5. Move TryRemoveImplicitConvert back out

    @roji
    roji committed Jun 12, 2020
    Configuration menu
    Copy the full SHA
    40f26ff View commit details
    Browse the repository at this point in the history

  6. DRY out RemoveObjectConvert

    @roji
    roji committed Jun 12, 2020
    Configuration menu
    Copy the full SHA
    9f107a4 View commit details
    Browse the repository at this point in the history