-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce allocations in EntityType by short-circuiting #21708
Conversation
Hello @AndriySvyryd! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
@msftbot Require 1 sign off |
Hello @AndriySvyryd! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
=> ToEnumerable(FindForeignKey(properties, principalKey, principalEntityType)) | ||
=> _directlyDerivedTypes.Count == 0 | ||
? ToEnumerable(FindForeignKey(properties, principalKey, principalEntityType)) | ||
: ToEnumerable(FindForeignKey(properties, principalKey, principalEntityType)) | ||
.Concat(FindDerivedForeignKeys(properties, principalKey, principalEntityType)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indent this a little.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Too late. We'll do a global reformatting closer to RTM.
Part of #21674