-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redo pubternalyzer with Roslyn Operations #21996
Changes from all commits
cf3db52
8488397
f44a136
28d090c
e8dd3f5
80a452e
b730e30
3514b51
b27e8a7
2fcd169
f8c7056
68108d2
6d185f5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
## Release 2.1.0 | ||
|
||
### New Rules | ||
Rule ID | Category | Severity | Notes | ||
--------|----------|----------|------- | ||
EF1000 | Usage | Warning | RawSqlStringInjectionDiagnosticAnalyzer, [Documentation](https://docs.microsoft.com/ef/core/querying/raw-sql) | ||
|
||
## Release 3.0.0 | ||
|
||
### New Rules | ||
Rule ID | Category | Severity | Notes | ||
--------|----------|----------|------- | ||
EF1001 | Usage | Warning | InternalUsageDiagnosticAnalyzer | ||
|
||
### Removed Rules | ||
Rule ID | Category | Severity | Notes | ||
--------|----------|----------|-------------------- | ||
EF1000 | Security | Disabled | RawSqlStringInjectionDiagnosticAnalyzer, [Documentation](https://docs.microsoft.com/ef/core/querying/raw-sql) |
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -82,13 +82,17 @@ public class MigrationsModelDiffer : IMigrationsModelDiffer | |
public MigrationsModelDiffer( | ||
[NotNull] IRelationalTypeMappingSource typeMappingSource, | ||
[NotNull] IMigrationsAnnotationProvider migrationsAnnotations, | ||
#pragma warning disable EF1001 // Internal EF Core API usage. | ||
[NotNull] IChangeDetector changeDetector, | ||
#pragma warning restore EF1001 // Internal EF Core API usage. | ||
[NotNull] IUpdateAdapterFactory updateAdapterFactory, | ||
[NotNull] CommandBatchPreparerDependencies commandBatchPreparerDependencies) | ||
{ | ||
Check.NotNull(typeMappingSource, nameof(typeMappingSource)); | ||
Check.NotNull(migrationsAnnotations, nameof(migrationsAnnotations)); | ||
#pragma warning disable EF1001 // Internal EF Core API usage. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. /cc @bricelam There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'll defer to @AndriySvyryd on these since they're here for seed data There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Filed #22063 |
||
Check.NotNull(changeDetector, nameof(changeDetector)); | ||
#pragma warning restore EF1001 // Internal EF Core API usage. | ||
Check.NotNull(updateAdapterFactory, nameof(updateAdapterFactory)); | ||
Check.NotNull(commandBatchPreparerDependencies, nameof(commandBatchPreparerDependencies)); | ||
|
||
|
@@ -137,7 +141,9 @@ public MigrationsModelDiffer( | |
/// any release. You should only use it directly in your code with extreme caution and knowing that | ||
/// doing so can result in application failures when updating to a new Entity Framework Core release. | ||
/// </summary> | ||
#pragma warning disable EF1001 // Internal EF Core API usage. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @bricelam same |
||
protected virtual IChangeDetector ChangeDetector { get; } | ||
#pragma warning restore EF1001 // Internal EF Core API usage. | ||
|
||
/// <summary> | ||
/// This is an internal API that supports the Entity Framework Core infrastructure and not subject to | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you already know about these internal usages @AndriySvyryd, but just in case.