Create GraphUpdatesTests for owned entities #23212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
reviewed
Nov 6, 2020
test/EFCore.SqlServer.FunctionalTests/GraphUpdates/GraphUpdatesSqlServerTest.cs
Outdated
Show resolved
Hide resolved
|
You just added 1622 new tests 😮 |
|
Can I piggy-back on this PR? 🐖 (Can also submit the fix to main directly)
|
|
Feel free to do either one |
|
@AndriySvyryd So happy to see this testing! It's been on my TODO list forever. |
ajcvickers
approved these changes
Nov 9, 2020
AndriySvyryd
force-pushed
the
Issue16454
branch
from
86b290d
to
0ba7d14
Compare
|
I disabled special-casing for owned entities that allowed reparenting of non-added entities with identifying FKs. #19135 would be the proper way of doing that, but if we don't revert the behavior I also filed dotnet/EntityFramework.Docs#2859 |
AndriySvyryd
force-pushed
the
Issue16454
branch
from
0ba7d14
to
af53e2e
Compare
AndriySvyryd
force-pushed
the
Issue16454
branch
2 times, most recently
from
e472efe
to
13f8955
Compare
Disable owned entity reparenting if it leads to key modification Fix default SQL Server value generation strategy for shared columns Fixes #16454
AndriySvyryd
force-pushed
the
Issue16454
branch
from
13f8955
to
f481b97
Compare
smitpatel
approved these changes
Nov 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable owned entity reparenting if it leads to key modification
Fix default SQL Server value generation strategy for shared columns
Query: Detect parent identifier correctly when parent has owned navs
Fixes #16454