Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.0.1] Use default schema for view mappings #23278

Merged
merged 2 commits into from
Nov 12, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,9 @@ public static string GetDefaultViewSchema([NotNull] this IEntityType entityType)
return ownership.PrincipalEntityType.GetViewSchema();
}

return null;
var useOldBehavior = AppContext.TryGetSwitch("Microsoft.EntityFrameworkCore.Issue23274", out var isEnabled)
&& isEnabled;
return !useOldBehavior && GetViewName(entityType) != null ? entityType.Model.GetDefaultSchema() : null;
}

/// <summary>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -239,9 +239,16 @@ public void Views_work()
Test(
modelBuilder => modelBuilder.Entity("Vista").ToView("Vista"),
new ModelCodeGenerationOptions { UseDataAnnotations = true },
code => Assert.Contains(".ToView(\"Vista\")", code.ContextFile.Code),
model => Assert.NotNull(
model.FindEntityType("TestNamespace.Vista").FindAnnotation(RelationalAnnotationNames.ViewDefinitionSql)));
code => Assert.Contains("entity.ToView(\"Vista\");", code.ContextFile.Code),
model => {
var entityType = model.FindEntityType("TestNamespace.Vista");

Assert.NotNull(entityType.FindAnnotation(RelationalAnnotationNames.ViewDefinitionSql));
Assert.Equal("Vista", entityType.GetViewName());
Assert.Null(entityType.GetViewSchema());
Assert.Null(entityType.GetTableName());
Assert.Null(entityType.GetSchema());
});
}

[ConditionalFact]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,42 @@ public void Gets_model_schema_if_schema_on_entity_type_not_set()
Assert.Null(entityType.GetSchema());
}

[ConditionalFact]
public void Can_get_and_set_view_schema_name_on_entity_type()
{
var modelBuilder = new ModelBuilder();

var entityType = modelBuilder
.Entity<Customer>()
.Metadata;

Assert.Null(entityType.GetViewSchema());

modelBuilder.HasDefaultSchema("dbo");

Assert.Null(entityType.GetViewSchema());

entityType.SetViewName("CustomerView");

Assert.Equal("dbo", entityType.GetViewSchema());

entityType.SetViewSchema(null);

Assert.Equal("dbo", entityType.GetViewSchema());

entityType.SetViewSchema("db0");

Assert.Equal("db0", entityType.GetViewSchema());

entityType.SetViewName(null);

Assert.Equal("db0", entityType.GetViewSchema());

entityType.SetViewSchema(null);

Assert.Null(entityType.GetViewSchema());
}

[ConditionalFact]
public void Can_get_and_set_column_type()
{
Expand Down