Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centralize and clean up diagnostic IDs #33415

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Centralize and clean up diagnostic IDs #33415

merged 1 commit into from
Mar 28, 2024

Conversation

roji
Copy link
Member

@roji roji commented Mar 27, 2024

Centralizes all diagnostic IDs in a new public EFDiagnostics class:

public static class EFDiagnostics
{
    public const string InternalUsage = "EF1001";
    public const string InterpolatedStringUsageInRawQueries = "EF1002";
    public const string SuppressUninitializedDbSetRule = "EFSPR1001";

    // Diagnostics for [Experimental]
    public const string ExperimentalApi = "EF9001";
    public const string ProviderExperimentalApi = "EF9002";
    public const string PrecompiledQueryExperimental = "EF9100";
}

So EF9xxx is for all the experimental stuff, EF9001 is for user-facing experimental APIs which don't have a dedicated ID, EF9002 is for provider-facing ones, and EF9100 and above is for specific experimental feature IDs (such as precompiled queries).

@roji roji requested a review from a team March 27, 2024 16:01
@roji roji merged commit 8487da8 into dotnet:main Mar 28, 2024
7 checks passed
@roji roji deleted the DiagnosticIds branch March 28, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants