[release/9.0] Don't throw on non-transactional migration operation warning. #34830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maumar
approved these changes
Oct 4, 2024
|
Does this require documentation updates? |
No. We haven't written documentation for this yet 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34829
Description
In EF Core 9 we introduced a warning exception when a migration is applied, it contains more than one operation and one of them can't be executed in a transaction. However, we found that there are some non-transactional operations on SQL Server that cannot be separated into several migrations. So we decided to downgrade this to a logged warning.
Customer impact
Exception thrown when applying a migration in the above scenario.
How found
App writing.
Regression
No, new feature
Testing
Tested manually.
Risk
Low.