Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp decimal literal tests #17836

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

esbenbjerre
Copy link
Contributor

@esbenbjerre esbenbjerre commented Oct 4, 2024

This PR updates the IL tests for decimal literals to better reflect the initialization chain (see discussion in #17769).

I'm unsure whether I've added too much IL compared to existing tests. I attempted to shrink it but it proved difficult since there's two identical lines with .method private specialname rtspecialname static void .cctor() cil managed and the verifyIL function got them confused.

@esbenbjerre esbenbjerre requested a review from a team as a code owner October 4, 2024 14:33
Copy link
Contributor

github-actions bot commented Oct 4, 2024

✅ No release notes required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: New
Development

Successfully merging this pull request may close these issues.

2 participants