Skip to content

Commit

Permalink
Convert PcaTransform to Estimator API (#1333)
Browse files Browse the repository at this point in the history
* Added placeholder

* Cleaned up Infos (replaced with ColumnPairs)

* Added ColumnInfo

* Added all the Create() methods.

* Added Mapper

* Commented out the EntryPoint

* Added PcaEstimator2

* PcaWorkout test passes

* Added pigsty api

* Fixed EntryPoint

* Fixed the arguments

* Fixed tests and added pigsty test

* Deleted Wrapped PCA transform

* Float -> float

* Cleaned docstrings

* Removed some unnecessary checks

* Simplified unnecessary code

* Moved some fields to ColumnInfo for simplifications

* Simplified weight columns

* Address PR comments #1

* Addressed PR comments #2

* Moved the static test

* PR comments #3

* Moved schema related information out of ColumnInfo and into Mapper.ColumnSchemaInfo.

* PR comments

* PR comments

* Updated manifest for entrypoint PcaCalculator

* Fixed schema exceptions
  • Loading branch information
shmoradims authored Oct 25, 2018
1 parent a44386d commit b056d08
Show file tree
Hide file tree
Showing 5 changed files with 457 additions and 320 deletions.
Loading

0 comments on commit b056d08

Please sign in to comment.