-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Making TensorFlowTransform trainable. #1063
Merged
Merged
Changes from 16 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
22d08d6
Making TensorflowTransform trainable.
zeahmed 1fc443a
Merge remote-tracking branch 'upstream/master' into tf_training
zeahmed ef67dd1
Added model files and script to create model in python.
zeahmed c1eafa6
Added functionality to serialized TensorFlow model after retraining.
zeahmed 07ae61c
Added comments. Added checking for parameters and types.
zeahmed 6ec4a5a
Merge remote-tracking branch 'upstream/master' into tf_training
zeahmed 36bf551
Addressed reviewers' comments.
zeahmed 570bd02
Addressed reviewers' comments.
zeahmed 3cc20e4
Added more tests...
zeahmed 49bdf59
Merge remote-tracking branch 'upstream/master' into tf_training
zeahmed a9a90ab
Fixed failing tests.
zeahmed 345c504
Using progress channel to report metrics.
zeahmed 883f9b4
Moved models to models repo.
zeahmed 18c70f3
Removed extra array copy.
zeahmed 8ea8e9d
Addressed reviewers' comments.
zeahmed 735f7ca
Addressed reviewers' comments.
zeahmed 9c07a53
Addressed reviewers' comments.
zeahmed 14ec78b
Addressed reviewers' comments.
zeahmed afb3ca1
Addressed reviewers' comments.
zeahmed 5a6cc08
Added try-finally in tests so that folders are deleted even when ther…
zeahmed 4297376
Merge conflicts.
zeahmed c0fe791
Merge remote-tracking branch 'upstream/master' into tf_training
zeahmed 0984b0f
Merge remote-tracking branch 'upstream/master' into tf_training
zeahmed 18040ca
Merge branch 'tf_training' of https://github.com/zeahmed/machinelearn…
zeahmed File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -290,7 +290,7 @@ public TFStatus() : base(TF_NewStatus()) | |
|
||
// extern void TF_DeleteStatus (TF_Status *); | ||
[DllImport(NativeBinding.TensorFlowLibrary)] | ||
private static extern unsafe void TF_DeleteStatus(TF_Status status); | ||
internal static extern unsafe void TF_DeleteStatus(TF_Status status); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Can this one and TF_GetCode go back to being private? #Closed |
||
|
||
internal override void NativeDispose(IntPtr handle) | ||
{ | ||
|
@@ -313,7 +313,7 @@ public void SetStatusCode(TFCode code, string msg) | |
|
||
// extern TF_Code TF_GetCode (const TF_Status *s); | ||
[DllImport(NativeBinding.TensorFlowLibrary)] | ||
private static extern unsafe TFCode TF_GetCode(TF_Status s); | ||
internal static extern unsafe TFCode TF_GetCode(TF_Status s); | ||
|
||
/// <summary> | ||
/// Gets the status code for the status code. | ||
|
@@ -1666,7 +1666,13 @@ internal enum TFDataType : uint | |
/// <summary> | ||
/// 64-bit unsigned integers | ||
/// </summary> | ||
UInt64 = 23 | ||
UInt64 = 23, | ||
|
||
/// <summary> | ||
/// Float reference type. It used for defining types of Variables. | ||
/// Please https://www.tensorflow.org/api_docs/python/tf/DType for more details. | ||
/// </summary> | ||
Float_ref = 101 | ||
} | ||
|
||
/// <summary> | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
using (var status ...) #Resolved