Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #2718 from model builder #6768

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

LittleLittleCloud
Copy link
Contributor

We are excited to review your PR.

So we can do the best job, please check:

  • There's a descriptive title that will make sense to other developers some time from now.
  • There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format Fixes #nnnn in your description to cause GitHub to automatically close the issue(s) when your PR is merged.
  • Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
  • You have included any necessary tests in the same PR.

fix dotnet/machinelearning-modelbuilder#2718

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #6768 (c014dcc) into main (caee3c2) will increase coverage by 0.01%.
The diff coverage is 97.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6768      +/-   ##
==========================================
+ Coverage   68.88%   68.90%   +0.01%     
==========================================
  Files        1216     1216              
  Lines      251137   251401     +264     
  Branches    26269    26322      +53     
==========================================
+ Hits       172997   173228     +231     
+ Misses      71313    71302      -11     
- Partials     6827     6871      +44     
Flag Coverage Δ
Debug 68.90% <97.66%> (+0.01%) ⬆️
production 63.40% <95.29%> (+0.01%) ⬆️
test 88.93% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Microsoft.Data.Analysis/DataFrame.IO.cs 80.60% <ø> (-0.17%) ⬇️
....Data.Analysis/DataFrameColumn.BinaryOperations.cs 0.00% <0.00%> (ø)
...a.Analysis/PrimitiveDataFrameColumnComputations.cs 50.37% <ø> (+0.56%) ⬆️
src/Microsoft.Data.Analysis/DateTimeComputation.cs 39.16% <100.00%> (+2.64%) ⬆️
...icrosoft.Data.Analysis/PrimitiveColumnContainer.cs 87.19% <100.00%> (+3.57%) ⬆️
...lysis/PrimitiveDataFrameColumn.BinaryOperations.cs 41.52% <100.00%> (+0.06%) ⬆️
....Analysis/PrimitiveDataFrameColumn.Computations.cs 77.77% <100.00%> (ø)
...oft.Data.Analysis/PrimitiveDataFrameColumn.Sort.cs 87.34% <100.00%> (ø)
...icrosoft.Data.Analysis/PrimitiveDataFrameColumn.cs 81.39% <100.00%> (+0.52%) ⬆️
...Analysis/StringDataFrameColumn.BinaryOperations.cs 82.78% <100.00%> (+3.37%) ⬆️
... and 1 more

... and 8 files with indirect coverage changes

@michaelgsharp michaelgsharp merged commit 7b6af06 into dotnet:main Jul 24, 2023
23 checks passed
@ghost ghost locked as resolved and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text-Classification: Invocation exception when cross-validation
2 participants