Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistent null handling in DataFrame Arithmetics #6770

Merged
merged 5 commits into from
Aug 31, 2023
Merged

Fix inconsistent null handling in DataFrame Arithmetics #6770

merged 5 commits into from
Aug 31, 2023

Conversation

asmirnov82
Copy link
Contributor

Fixes #5650

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #6770 (99bbe5d) into main (39235a7) will decrease coverage by 0.06%.
The diff coverage is 50.82%.

@@            Coverage Diff             @@
##             main    #6770      +/-   ##
==========================================
- Coverage   69.03%   68.97%   -0.06%     
==========================================
  Files        1237     1237              
  Lines      252700   253459     +759     
  Branches    26446    26536      +90     
==========================================
+ Hits       174449   174825     +376     
- Misses      71308    71683     +375     
- Partials     6943     6951       +8     
Flag Coverage Δ
Debug 68.97% <50.82%> (-0.06%) ⬇️
production 63.54% <48.39%> (-0.07%) ⬇️
test 88.84% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage
...ata.Analysis/PrimitiveDataFrameColumnArithmetic.cs 48.27%
...t.Data.Analysis/PrimitiveColumnContainerHelpers.cs 100.00%
...st/Microsoft.Data.Analysis.Tests/DataFrameTests.cs 100.00%

@asmirnov82
Copy link
Contributor Author

Hello @JakeRadMSFT ,
conflict that prevented this PR from being merged into dev is solved now. Could you please perform a merge?

@michaelgsharp
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@michaelgsharp michaelgsharp merged commit e6a88c4 into dotnet:main Aug 31, 2023
23 checks passed
@asmirnov82 asmirnov82 deleted the 5650_inconsistent_null_handling_dataframe_arithmetic branch August 31, 2023 17:34
@ghost ghost locked as resolved and limited conversation to collaborators Sep 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DataFrame] Inconsistent null handling in DataFrameColumn arithmetic
3 participants