Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Windows] Fix crash with second window and WebView #10013

Closed
wants to merge 3 commits into from
Closed

[Windows] Fix crash with second window and WebView #10013

wants to merge 3 commits into from

Conversation

jsuarezruiz
Copy link
Contributor

@jsuarezruiz jsuarezruiz commented Sep 9, 2022 •
edited
Loading

Description of Change

Fix crash with second window and WebView on Windows.

Issues Fixed

Fixes #8323
Fixes #7317

@jsuarezruiz jsuarezruiz added t/bug Something isn't working platform/windows 🪟 high It doesn't work at all, crashes or has a big impact. area-controls-webview WebView labels Sep 9, 2022
@ghost ghost added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Sep 9, 2022
@namazso
Copy link

namazso commented Sep 9, 2022

Note that this is not quite the universal fix, the issue will resurface every time there's two threadpooltimers that are left to the GC to clean up. WebView just happens to be one of the offenders. Allocations of now unloaded modules should be considered leaked already, instead of turning the language into C.

@rmarinho
Copy link
Member

Can we add a device test ?

@jsuarezruiz
Copy link
Contributor Author

To help focus and move faster, we're going to have fewer open PRs and focus on the ones we'll be working on in each release. This PR is not included in the next release so I close it for now. I will reopen it and adapt to changes later.

@jsuarezruiz jsuarezruiz closed this Nov 3, 2022
@namazso
Copy link

namazso commented Nov 3, 2022 •
edited
Loading

I hope the crashing will be listed as a feature for WebViews at least for next release, was kind of hard to track down this easter egg of a feature.

I seriously wonder how can an entire control being broken not be a blocker for a release but here we are...

@BlueHippoGithub
Copy link

Any updates on when the fix is being released?

@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2023
@Eilon Eilon removed the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label May 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattleibow mattleibow Awaiting requested review from mattleibow

@PureWeen PureWeen Awaiting requested review from PureWeen

Assignees
No one assigned
Labels
area-controls-webview WebView high It doesn't work at all, crashes or has a big impact. platform/windows 🪟 t/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

App crashes with second window and WebView Windows app gets a unknown win32 error on exit
5 participants
@jsuarezruiz @namazso @rmarinho @BlueHippoGithub @Eilon