Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update net8.0 from main #13437

Merged
merged 4 commits into from
Feb 18, 2023
Merged

Update net8.0 from main #13437

merged 4 commits into from
Feb 18, 2023

Conversation

Redth
Copy link
Member

@Redth Redth commented Feb 18, 2023

Brings especially in, the fix for adding an implicit reference to the Combat package.

Redth and others added 4 commits February 17, 2023 15:11
Ultimately we want this to be an implicit reference which is not included by default and opt-in, however visual studio's Live Visual tree currently depends on the assembly existing and being loaded so we cannot yet remove it.

The default property assignment can be removed once VS is ready for this.
* Add shell pages via controller instead of handler

* Auto-format source code

* - cleanup

* - add wait

* - push test into modal to isolate better

---------

Co-authored-by: GitHub Actions Autoformatter <autoformat@example.com>
* Use and clear a local nuget cache

* more
#13336)

* Have Frame use MinimumHeight/Width for minimums instead of constraints
Fixes #13074

* Auto-format source code

* Adjust test for other screen sizes/densities

* Update src/Controls/src/Core/Compatibility/Handlers/Android/FrameRenderer.cs

Co-authored-by: Manuel de la Pena <mandel@microsoft.com>

* Make legacy min Frame size a constant

* Auto-format source code

* Make Frame test less awkward

* Auto-format source code

---------

Co-authored-by: GitHub Actions Autoformatter <autoformat@example.com>
Co-authored-by: Manuel de la Pena <mandel@microsoft.com>
@Redth Redth enabled auto-merge (squash) February 18, 2023 15:34
PureWeen
PureWeen previously approved these changes Feb 18, 2023
@Redth Redth disabled auto-merge February 18, 2023 16:10
@Redth Redth enabled auto-merge February 18, 2023 16:11
@PureWeen PureWeen dismissed their stale review February 18, 2023 16:13

Changed commit strategy

@Redth Redth merged commit d8656a7 into net8.0 Feb 18, 2023
@ghost ghost added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Jul 11, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2023
@Eilon Eilon removed the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label May 10, 2024
@samhouts samhouts added the fixed-in-8.0.0-preview.1.7762 Look for this fix in 8.0.0-preview.1.7762! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-controls-frame Frame area-controls-shell Shell Navigation, Routes, Tabs, Flyout fixed-in-8.0.0-preview.1.7762 Look for this fix in 8.0.0-preview.1.7762! platform/android 🤖 platform/iOS 🍎
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants