Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] Fix Button image sizing and layout #22476

Merged
merged 73 commits into from
Aug 27, 2024
Merged

[iOS] Fix Button image sizing and layout #22476

merged 73 commits into from
Aug 27, 2024

Commits on Aug 26, 2024

  1. Changes from the original Button PR #21759

    @tj-devel709
    tj-devel709 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    84067e1 View commit details
    Browse the repository at this point in the history

  2. Move the button layout code to ArrangeOverride

    @tj-devel709
    tj-devel709 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    6bc8ab2 View commit details
    Browse the repository at this point in the history

  3. Add UITests and remove internal

    @tj-devel709
    tj-devel709 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    762721c View commit details
    Browse the repository at this point in the history

  4. Didn't add the screenshots

    @tj-devel709
    tj-devel709 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    61f06de View commit details
    Browse the repository at this point in the history

  5. Add MeasureOverride and related changes

    @tj-devel709
    tj-devel709 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    11c8bee View commit details
    Browse the repository at this point in the history

  6. Added snapshot

    @jsuarezruiz @tj-devel709
    jsuarezruiz authored and tj-devel709 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    616328c View commit details
    Browse the repository at this point in the history

  7. More snapshots

    @jsuarezruiz @tj-devel709
    jsuarezruiz authored and tj-devel709 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    5b2a233 View commit details
    Browse the repository at this point in the history

  8. add android screenshot 3/4

    @tj-devel709
    tj-devel709 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    38d809d View commit details
    Browse the repository at this point in the history

  9. add android screenshot 4/4

    @tj-devel709
    tj-devel709 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    55e1ac2 View commit details
    Browse the repository at this point in the history

  10. add additional UITest

    @tj-devel709
    tj-devel709 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    4fdb78b View commit details
    Browse the repository at this point in the history

  11. comments and android snapshot 1/4

    @tj-devel709
    tj-devel709 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    f91cd07 View commit details
    Browse the repository at this point in the history

  12. Add BorderWidth to the calculations

    @tj-devel709
    tj-devel709 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    e252e0f View commit details
    Browse the repository at this point in the history

  13. Android snapshot 2/4

    @tj-devel709
    tj-devel709 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    a6aae41 View commit details
    Browse the repository at this point in the history

  14. add text to sample button

    @tj-devel709
    tj-devel709 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    c19a8aa View commit details
    Browse the repository at this point in the history

  15. Android snapshot 2/4 redo

    @tj-devel709
    tj-devel709 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    47a6948 View commit details
    Browse the repository at this point in the history

  16. borderWidth UITest

    @tj-devel709
    tj-devel709 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    de30c55 View commit details
    Browse the repository at this point in the history

  17. iOS borderwidth screenshots

    @tj-devel709
    tj-devel709 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    b8f96ce View commit details
    Browse the repository at this point in the history

  18. add to unshipped

    @tj-devel709
    tj-devel709 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    b33d9b8 View commit details
    Browse the repository at this point in the history

  19. Not sure why this line was duplicated

    @tj-devel709
    tj-devel709 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    577ea40 View commit details
    Browse the repository at this point in the history

  20. add margins to measurements and more screenshots

    @tj-devel709
    tj-devel709 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    a296110 View commit details
    Browse the repository at this point in the history

  21. more android and windows screenshots

    @tj-devel709
    tj-devel709 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    d13c20c View commit details
    Browse the repository at this point in the history

  22. add borderColor since it is not default on Android

    @tj-devel709
    tj-devel709 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    fe9a844 View commit details
    Browse the repository at this point in the history

  23. more screenshots

    @tj-devel709
    tj-devel709 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    8599f01 View commit details
    Browse the repository at this point in the history

  24. Move layout and measure code into the MeasureArrange

    @tj-devel709
    tj-devel709 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    a26514d View commit details
    Browse the repository at this point in the history

  25. Use the correct spacing for sizing the image up - improved behavior

    @tj-devel709
    tj-devel709 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    97c7ddc View commit details
    Browse the repository at this point in the history

  26. Use better measurements for the title

    @tj-devel709
    tj-devel709 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    ed3f7ae View commit details
    Browse the repository at this point in the history

  27. Remove removed method

    @tj-devel709
    tj-devel709 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    ce8c05b View commit details
    Browse the repository at this point in the history

  28. Add special case for vertical image placements and non-fill horizonta… 

    …l option. Also add maybe temporary fix for button in grid having new constraints in arrangeOverride
    @tj-devel709
    tj-devel709 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    5976da5 View commit details
    Browse the repository at this point in the history

  29. Round the measured size up to try to match existing behavior

    @tj-devel709
    tj-devel709 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    467e7c5 View commit details
    Browse the repository at this point in the history

  30. try just using the regular boundingRect

    @tj-devel709
    tj-devel709 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    fe2787a View commit details
    Browse the repository at this point in the history

  31. Move arranging code to ArrangeOverride

    @tj-devel709
    tj-devel709 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    0014873 View commit details
    Browse the repository at this point in the history

  32. clean up and sometimes use the DeviceMetrics for boundingRect

    @tj-devel709
    tj-devel709 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    4abe761 View commit details
    Browse the repository at this point in the history

  33. More documentation and clean up

    @tj-devel709
    tj-devel709 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    fda1392 View commit details
    Browse the repository at this point in the history

  34. Update screenshots

    @tj-devel709
    tj-devel709 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    06ff062 View commit details
    Browse the repository at this point in the history

  35. wrong operator and fix documentation

    @tj-devel709
    tj-devel709 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    dc8bc04 View commit details
    Browse the repository at this point in the history

  36. Add back in the margin calculation. This was lost on accident

    @tj-devel709
    tj-devel709 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    41a26e1 View commit details
    Browse the repository at this point in the history

  37. Always add the margin to our measureArrange Size

    @tj-devel709
    tj-devel709 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    33187ce View commit details
    Browse the repository at this point in the history

  38. Use the CrossPlatformLayout similar to MauiView

    @tj-devel709
    tj-devel709 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    c4114d4 View commit details
    Browse the repository at this point in the history

  39. Remove changes to UITest.cs

    @tj-devel709
    tj-devel709 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    4130f8e View commit details
    Browse the repository at this point in the history

  40. Update UITest Snapshots

    @tj-devel709
    tj-devel709 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    c031728 View commit details
    Browse the repository at this point in the history

  41. fix the unshipped.txt files

    @tj-devel709
    tj-devel709 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    72389fd View commit details
    Browse the repository at this point in the history

  42. next wave of new screenshots

    @tj-devel709
    tj-devel709 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    eb85e4d View commit details
    Browse the repository at this point in the history

  43. next wave of new screenshots 2

    @tj-devel709
    tj-devel709 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    fb0a21c View commit details
    Browse the repository at this point in the history

  44. add delay to UITest and update more screenshots

    @tj-devel709
    tj-devel709 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    060ce04 View commit details
    Browse the repository at this point in the history

  45. removing the spacing parameter and refactor the titleRect

    @tj-devel709
    tj-devel709 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    3e8421b View commit details
    Browse the repository at this point in the history

  46. try to use exact width of title if available and allow more space for… 

    … title
    @tj-devel709
    tj-devel709 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    4f0c5e0 View commit details
    Browse the repository at this point in the history

  47. change tests and other various small fixes

    @tj-devel709
    tj-devel709 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    b99484d View commit details
    Browse the repository at this point in the history

  48. Remove padding from titleRect measurements

    @tj-devel709
    tj-devel709 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    bc589e4 View commit details
    Browse the repository at this point in the history

  49. Add required padding in scenarios to not truncate text if padding not… 

    … set and add back in padding and spacing in buttons that have image on left and right
    @tj-devel709
    tj-devel709 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    69c51cc View commit details
    Browse the repository at this point in the history

  50. manually measure titleRect on first measure in case elements are pres… 

    …ent but changed and add additional checks for titles and images existing
    @tj-devel709
    tj-devel709 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    edca1e4 View commit details
    Browse the repository at this point in the history

  51. re-enable updatePadding since ImageButton relies on it

    @tj-devel709
    tj-devel709 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    9542cea View commit details
    Browse the repository at this point in the history

  52. new screenshots 1

    @tj-devel709
    tj-devel709 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    c57ee0b View commit details
    Browse the repository at this point in the history

  53. new screenshots 2

    @tj-devel709
    tj-devel709 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    a064401 View commit details
    Browse the repository at this point in the history

  54. new screenshots 3

    @tj-devel709
    tj-devel709 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    18af3d7 View commit details
    Browse the repository at this point in the history

  55. new screenshots 4

    @tj-devel709
    tj-devel709 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    a2677ab View commit details
    Browse the repository at this point in the history

  56. Add multiple screens of button tests

    @tj-devel709
    tj-devel709 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    857f714 View commit details
    Browse the repository at this point in the history

  57. add using statements

    @tj-devel709
    tj-devel709 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    990f2e9 View commit details
    Browse the repository at this point in the history

  58. use the right issue

    @tj-devel709
    tj-devel709 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    834294b View commit details
    Browse the repository at this point in the history

  59. new test screenshots 1

    @tj-devel709
    tj-devel709 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    fdf1a9b View commit details
    Browse the repository at this point in the history

  60. new test screenshots 2

    @tj-devel709
    tj-devel709 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    675a120 View commit details
    Browse the repository at this point in the history

  61. new test screenshots 3

    @tj-devel709
    tj-devel709 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    16cb06c View commit details
    Browse the repository at this point in the history

  62. some extra clean up

    @tj-devel709
    tj-devel709 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    9694bb6 View commit details
    Browse the repository at this point in the history

  63. add comment and include the right image

    @tj-devel709
    tj-devel709 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    3df2e90 View commit details
    Browse the repository at this point in the history

  64. new test screenshots 4

    @tj-devel709
    tj-devel709 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    b854e0d View commit details
    Browse the repository at this point in the history

  65. add automation ID and try changing ios screenshot again

    @tj-devel709
    tj-devel709 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    046ddf5 View commit details
    Browse the repository at this point in the history

  66. use the spacing appropriately in the top and bottom image buttons

    @tj-devel709
    tj-devel709 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    bf7846f View commit details
    Browse the repository at this point in the history

  67. more screenshots

    @tj-devel709
    tj-devel709 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    f32cf48 View commit details
    Browse the repository at this point in the history

  68. screenshots from ci

    @tj-devel709
    tj-devel709 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    7a5bbcc View commit details
    Browse the repository at this point in the history

  69. more screenshots from cake tool

    @tj-devel709
    tj-devel709 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    1168862 View commit details
    Browse the repository at this point in the history

  70. remove waiting for grid on windows uitest

    @tj-devel709
    tj-devel709 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    0c2bdf8 View commit details
    Browse the repository at this point in the history

  71. try windows uiscreenshots manually created

    @tj-devel709
    tj-devel709 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    b6f0925 View commit details
    Browse the repository at this point in the history

  72. new screenshots

    @tj-devel709
    tj-devel709 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    5ea2ffc View commit details
    Browse the repository at this point in the history

  73. new screenshots 2

    @tj-devel709
    tj-devel709 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    61886b8 View commit details
    Browse the repository at this point in the history