Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ios/catalyst] fix memory leak in TabbedPage #23166

Merged
merged 2 commits into from
Jun 21, 2024
Merged

[ios/catalyst] fix memory leak in TabbedPage #23166

merged 2 commits into from
Jun 21, 2024

Commits on Jun 21, 2024

  1. [ios/catalyst] fix memory leak in TabbedPage 

    Context: dotnet#23164

Just the same way as `NavigationPage` in dotnet#23164, `TabbedPage` also has
a memory leak caused by the cycle:

* `TabbedPage` -> `TabbedRenderer` -> `VisualElement _element;` -> `TabbedPage

I could add a new `[Theory]` in `MemoryTests.cs` to see the issue.

This PR fixes the memory leak by breaking the cycle in `TabbedRenderer`.
    @jonathanpeppers
    jonathanpeppers committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    9201fe0 View commit details
    Browse the repository at this point in the history

  2. Ignore test on Windows 

    I also cleaned up the Task.Delay()
    @jonathanpeppers
    jonathanpeppers committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    53759aa View commit details
    Browse the repository at this point in the history