Make sure resizetized image files are writable #23412
Merged
+13
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes dotnet#23397 Commit ff5f3f0 added code which "touches" a file to make sure its LastWrite time is up to date. This was to help solve certain build issues. However there was an oversight. Certain source control systems always check out files `readonly`. In these cases the file attributes are copied when we make a copy of a file to be resizetized. When that happens we end up with the following error. ``` Access to the path 'Debug\net8.0-android\resizetizer\r\drawable\foo.png' is denied. ``` To fix this lets make sure that the file is writable before we try to update it. Also fix some formatting to make sure it matches.
|
@mattleibow any chance of a review on this one? |
mattleibow
approved these changes
Jul 12, 2024
rmarinho
approved these changes
Jul 15, 2024
samhouts
added
fixed-in-net9.0-nightly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23397
Commit ff5f3f0 added code which "touches" a file
to make sure its LastWrite time is up to date. This was to help solve certain build issues.
However there was an oversight. Certain source control systems always check out files
readonly. In these cases the file attributes are copied when we make a copy of a file to be resizetized. When that happens we end up with the following error.To fix this lets make sure that the file is writable before we try to update it.
Also fix some formatting to make sure it matches.