Update BenchmarkDotNet to 0.14.1-nightly.20240924.187 #4474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LoopedBard3
previously approved these changes
Sep 23, 2024
lewing
previously approved these changes
Sep 23, 2024
…vik-msft/performance into caaavik/update-bdn-23092024
|
Running the pipeline again, just on wasm and mono aot so should finish a bit faster. Once that is all good, will merge in. |
|
I moved the BDN ref from the middle to the bottom of the other references so it should cause fewer update conflicts |
caaavik-msft
changed the title
lewing
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is being done to pull the changes from dotnet/BenchmarkDotNet#2645 which will allow for us to run the wasm performance tests targeting .NET 9 while the .NET 10 SDK is installed. This should unblock dotnet/runtime#106599.
I have started a test run of the pipeline internally with this change and the .NET 10 change which I want to wait for before we merge this in.