Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate ref readonly in new synthetic call factory and unskip arglist tests #68951

Merged
merged 2 commits into from
Jul 12, 2023
Merged

Translate ref readonly in new synthetic call factory and unskip arglist tests #68951

merged 2 commits into from
Jul 12, 2023

Conversation

jjonescz
Copy link
Member

Changes that became possible only after merging main into the feature branch in #68950.
Test plan: #68056.

@jjonescz jjonescz added this to the C# 12.0 milestone Jul 10, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Issues and PRs which have not yet been triaged by a lead label Jul 10, 2023
@jjonescz jjonescz mentioned this pull request Jul 10, 2023
Merged
@jjonescz jjonescz force-pushed the RefReadonly-10-MainFollowUp branch 2 times, most recently from 4d99843 to 268a62a Compare July 10, 2023 11:10
@jjonescz jjonescz force-pushed the RefReadonly-10-MainFollowUp branch from 268a62a to 836d07b Compare July 10, 2023 12:29
@jjonescz jjonescz marked this pull request as ready for review July 10, 2023 13:59
@jjonescz jjonescz requested a review from a team as a code owner July 10, 2023 13:59
@jjonescz jjonescz requested review from AlekseyTs and jcouv July 10, 2023 13:59
AlekseyTs
AlekseyTs approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 2)

@jjonescz
Copy link
Member Author

@jcouv for a quick second review, thanks

@jcouv jcouv self-assigned this Jul 11, 2023
jcouv
jcouv approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 2)

@jaredpar jaredpar modified the milestones: C# 12.0, 17.8 Jul 11, 2023
@jjonescz jjonescz merged commit e10eb7f into dotnet:features/RefReadonly Jul 12, 2023
25 checks passed
@jjonescz jjonescz deleted the RefReadonly-10-MainFollowUp branch July 12, 2023 07:57
@allisonchou allisonchou mentioned this pull request Aug 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlekseyTs AlekseyTs AlekseyTs approved these changes

@jcouv jcouv jcouv approved these changes

Assignees

@jcouv jcouv

Labels
Area-Compilers New Feature - Ref Readonly Parameters `ref readonly` parameters untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.8
Development

Successfully merging this pull request may close these issues.
4 participants
@jjonescz @AlekseyTs @jcouv @jaredpar