Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable recommender for scoped keyword #70290

Merged
merged 4 commits into from
Oct 12, 2023
Merged

Enable recommender for scoped keyword #70290

merged 4 commits into from
Oct 12, 2023

Conversation

jhinder
Copy link
Contributor

@jhinder jhinder commented Oct 8, 2023

Fixes #66305.

@jhinder jhinder requested a review from a team as a code owner October 8, 2023 14:03
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Oct 8, 2023
@ghost ghost added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label Oct 8, 2023
@CyrusNajmabadi
Copy link
Member

An actual test would be good. You can add one to csharpcompletioncommandhandlertests. That's will help catch this sort of issue. Thanks!!

@jhinder
Copy link
Contributor Author

jhinder commented Oct 8, 2023

@CyrusNajmabadi Thanks for pointing me in the right direction. Added a simple test.

@DoctorKrolic
Copy link
Contributor

Same problem with automerge here

@CyrusNajmabadi CyrusNajmabadi merged commit 5b3d150 into dotnet:main Oct 12, 2023
24 checks passed
@CyrusNajmabadi
Copy link
Member

Thanks!

@ghost ghost added this to the Next milestone Oct 12, 2023
@jhinder jhinder deleted the enable-scoped-recommender branch October 13, 2023 14:11
@allisonchou allisonchou mentioned this pull request Oct 13, 2023
Closed
@jjonescz jjonescz modified the milestones: Next, 17.9 P1 Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

Assignees
No one assigned
Labels
Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee. untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.9 P1
Development

Successfully merging this pull request may close these issues.

scoped keyword not included in completion list
4 participants
@jhinder @CyrusNajmabadi @DoctorKrolic @jjonescz