Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System.Text.Json.Tests hang on a Checked CoreCLR #45464

Closed
safern opened this issue Dec 2, 2020 · 4 comments
Closed

System.Text.Json.Tests hang on a Checked CoreCLR #45464

safern opened this issue Dec 2, 2020 · 4 comments
Labels
area-System.Text.Json backlog-cleanup-candidate An inactive issue that has been marked for automated closure. disabled-test The test is disabled in source code against the issue
Milestone

Comments

@safern
Copy link
Member

safern commented Dec 2, 2020

https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-45451-merge-d5c2411bf7a94e53aa/System.Text.Json.Tests/console.8c3fdb0f.log?sv=2019-07-07&se=2020-12-22T01%3A58%3A57Z&sr=c&sp=rl&sig=jVvW5f1Z0z%2BebQhjuzWnYHsuErZs%2BRgJdJI0dR22FP4%3D

/private/tmp/helix/working/AACC08F8/w/BA4409BB/e /private/tmp/helix/working/AACC08F8/w/BA4409BB/e
  Discovering: System.Text.Json.Tests (method display = ClassAndMethod, method display options = None)
  Discovered:  System.Text.Json.Tests (found 2262 of 2294 test cases)
  Starting:    System.Text.Json.Tests (parallel test collections = on, max threads = 4)
   System.Text.Json.Tests: [Long Running Test] 'System.Text.Json.Serialization.Tests.ConstructorTests_String.ReadSimpleObjectAsync', Elapsed: 00:07:21
[Long Running Test] 'System.Text.Json.Tests.Utf8JsonWriterTests.Writing3MBBase64Bytes', Elapsed: 00:07:19
[Long Running Test] 'System.Text.Json.Serialization.Tests.ConstructorTests_Span.MultipleTypes', Elapsed: 00:07:24
[Long Running Test] 'System.Text.Json.Tests.JsonDocumentTests.ParseJson_UnseekableStream_Async_BadBOM', Elapsed: 00:06:39
[Long Running Test] 'System.Text.Json.Tests.Utf8JsonReaderTests.ReadInvalidJsonStringsWithComments', Elapsed: 00:02:03
[Long Running Test] 'System.Text.Json.Serialization.Tests.StreamTests.RoundTripAsync', Elapsed: 00:05:37
[Long Running Test] 'System.Text.Json.Serialization.Tests.NumberHandlingTests.DictionariesRoundTrip', Elapsed: 00:05:04
[Long Running Test] 'System.Text.Json.Serialization.Tests.ConstructorTests_Stream.MultipleTypes', Elapsed: 00:05:22
[Long Running Test] 'System.Text.Json.Serialization.Tests.ContinuationTests.ShouldWorkAtAnyPosition_Sequence', Elapsed: 00:04:02

Happened on OSX on a Checked CoreCLR.

I just checked on Kusto and this has happened 11 times in the past day.

Hit in: #45451

Maybe we just need to mark as SkipOnCoreClr("", RuntimeConfiguration.Checked)?

@safern safern added the blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' label Dec 2, 2020
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added area-System.Text.Json untriaged New issue has not been triaged by the area owner labels Dec 2, 2020
@safern
Copy link
Member Author

safern commented Dec 2, 2020

Related: #35927

@safern safern added disabled-test The test is disabled in source code against the issue and removed blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' labels Dec 4, 2020
@layomia
Copy link
Contributor

layomia commented Dec 7, 2020

Clean CI unblocked with #45505.

@layomia layomia removed the untriaged New issue has not been triaged by the area owner label Dec 7, 2020
@layomia layomia modified the milestones: 6.0.0, Future Dec 7, 2020
@ghost
Copy link

ghost commented Oct 15, 2021

Due to lack of recent activity, this issue has been marked as a candidate for backlog cleanup. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will undo this process.

This process is part of the experimental issue cleanup initiative we are currently trialing in a limited number of areas. Please share any feedback you might have in the linked issue.

@ghost
Copy link

ghost commented Nov 5, 2021

This issue will now be closed since it had been marked no recent activity but received no further activity in the past 14 days. It is still possible to reopen or comment on the issue, but please note that the issue will be locked if it remains inactive for another 30 days.

@ghost ghost closed this as completed Nov 5, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Dec 5, 2021
@eiriktsarpalis eiriktsarpalis added the backlog-cleanup-candidate An inactive issue that has been marked for automated closure. label Feb 18, 2022
@ghost ghost removed the no-recent-activity label Feb 18, 2022
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Text.Json backlog-cleanup-candidate An inactive issue that has been marked for automated closure. disabled-test The test is disabled in source code against the issue
Projects
None yet
Development

No branches or pull requests

4 participants