Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable Long Running JSON tests on Checked CoreCLR #45505

Merged
merged 2 commits into from
Dec 3, 2020
Merged

Disable Long Running JSON tests on Checked CoreCLR #45505

merged 2 commits into from
Dec 3, 2020

Conversation

safern
Copy link
Member

@safern safern commented Dec 2, 2020 •
edited
Loading

Relates to: #45464

layomia
layomia approved these changes Dec 3, 2020
View reviewed changes
Copy link
Contributor

@layomia layomia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments. LGTM assuming no CI issues due to this PR. Thanks!

src/libraries/System.Text.Json/tests/JsonDocumentTests.cs Outdated Show resolved Hide resolved
src/libraries/System.Text.Json/tests/Serialization/NumberHandlingTests.cs Outdated Show resolved Hide resolved
@runfoapp runfoapp bot mentioned this pull request Dec 3, 2020
Closed
@riarenas
Copy link
Member

riarenas commented Dec 3, 2020 •
edited
Loading

@safern we are still seeing hangs when running these tests and it looks like the errors are #45532 and #45524. should this be merged?

@safern
Copy link
Member Author

safern commented Dec 3, 2020

should this be merged?

I need to address PR feedback. Will address that and then merge.

@riarenas
Copy link
Member

riarenas commented Dec 3, 2020

I need to address PR feedback. Will address that and then merge.

probably should've looked further than just the approval 😋

@safern safern merged commit 87c3cb7 into dotnet:master Dec 3, 2020
@safern safern deleted the DisableJsonTestsCheckedCoreclr branch December 3, 2020 22:39
@layomia layomia mentioned this pull request Dec 7, 2020
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Jan 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@layomia layomia layomia approved these changes

@steveharter steveharter Awaiting requested review from steveharter

@ahsonkhan ahsonkhan Awaiting requested review from ahsonkhan

@jozkee jozkee Awaiting requested review from jozkee

Assignees
No one assigned
Labels
area-System.Text.Json
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@safern @riarenas @layomia @Dotnet-GitSync-Bot