Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the ICU time format conversion logic #103681

Merged
merged 13 commits into from
Jun 21, 2024
Merged

Fix the ICU time format conversion logic #103681

merged 13 commits into from
Jun 21, 2024

Commits on Jun 19, 2024

  1. Fix the ICU time format conversion logic 

    Revise the ICU time format conversion logic to support all unquoted literal texts and the `B` and `b` pattern symbols.

Fix dotnet#103592
    @PopSlime
    PopSlime committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    e61e7ab View commit details
    Browse the repository at this point in the history

  2. Clarify literal texts in the conversion logic

    @PopSlime
    PopSlime committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    f6c8668 View commit details
    Browse the repository at this point in the history

  3. Add tests for verifying time patterns 

    Add tests verifying that all the short and long time patterns either use
a 24-hour clock or have an AM/PM designator.
    @PopSlime
    PopSlime committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    06b1118 View commit details
    Browse the repository at this point in the history

  4. Fix literal single quote and literal backslash conversion

    @PopSlime
    PopSlime committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    df099b9 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2024

  1. Refactor the literal quote conversion logic

    @PopSlime
    PopSlime committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    b6a651e View commit details
    Browse the repository at this point in the history

  2. Revise the test logic to ignore literal texts and check pattern redun… 

    …dancy

Modify the test logic so that it recognizes literal texts correctly, and
fails if 12-hour and 24-hour clocks are used at the same time.
    @PopSlime
    PopSlime committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    26b4462 View commit details
    Browse the repository at this point in the history

  3. Revise the test logic to ensure all cultures are tested

    @PopSlime
    PopSlime committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    8f1ccf7 View commit details
    Browse the repository at this point in the history

  4. Add comments to clarify the backslash conversion

    @PopSlime
    PopSlime committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    753d2f1 View commit details
    Browse the repository at this point in the history

  5. Refactor the conversion logic 

    Simplify some logic and improve readability.
    @PopSlime
    PopSlime committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    347dd36 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2024

  1. Exclude bad ICU patterns from the tests

    @PopSlime
    PopSlime committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    b908c7b View commit details
    Browse the repository at this point in the history

  2. Exclude the VerifyTimePatterns tests from hybrid globalization on bro… 

    …wser
    @PopSlime
    PopSlime committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    7d95dbb View commit details
    Browse the repository at this point in the history

  3. Add missing usings

    @PopSlime
    PopSlime committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    3446a10 View commit details
    Browse the repository at this point in the history

  4. Improve readability of the for-loops

    @PopSlime
    PopSlime committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    e205dbc View commit details
    Browse the repository at this point in the history