-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] Fix return type marshalling on IsKeyStorePrivateKeyEntry #103825
[Android] Fix return type marshalling on IsKeyStorePrivateKeyEntry #103825
Conversation
Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones |
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
Should we fix the rest of the cases that use |
Those are existing p/invokes, and they "work" given that the C-bool we are using happen to be 1-byte. This is a clear mismatch though. I think we should backport this PR to |
The failing runtime-extra-platforms tests are unrelated |
This PR addresses #103337 (comment): the C code returns
int32_t
and the managed side specified wrong type./cc @akoeplinger @vcsjones