ARm64/Sve: Fix the SVE_ComputeAddress* #104039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
@dotnet/arm64-contrib |
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
TIHan
approved these changes
Jun 26, 2024
a74nh
approved these changes
Jun 26, 2024
We cannot, there is an expectation that the intrinsics are ordered alphabetically now so that resolution can be done via a binary search. |
src/coreclr/jit/hwintrinsicarm64.cpp
Outdated
| case NI_Sve_Compute32BitAddresses: | ||
| return 2; | ||
| case NI_Sve_Compute64BitAddresses: | ||
| return 4; |
There was a problem hiding this comment.
Is this meant to be 4? I thought you had it commented as 3 in the prior commit?
There was a problem hiding this comment.
yes, that is a typo. Great catch.
This was referenced Jun 26, 2024
Open
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #103778, we readjusted the ordering, but didn't encode that information in the instruction correctly.
https://github.com/dotnet/runtime/pull/103778/files#diff-3a0ae3f52b3651d14625d26a4ff55d5028a7116a6f8375a6ca13caa44ed8685f