Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ILCompiler package reference #107583

Merged
merged 6 commits into from
Sep 12, 2024
Merged

Remove ILCompiler package reference #107583

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5e4f7c5
Remove ILCompiler package reference
agocke Sep 9, 2024
7c18c0d
Respond to PR comments
agocke Sep 10, 2024
af313d9
Move ILCompiler overrides to the top level in liveBuilds
agocke Sep 11, 2024
7eb704a
Merge remote-tracking branch 'upstream/main' into remove-ilcompiler-p…
agocke Sep 11, 2024
24dfbf8
Update eng/Versions.props
agocke Sep 11, 2024
f1dea4d
Fix bad merge
agocke Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions eng/Version.Details.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,10 +304,6 @@
<Sha>7cb32e193a55a95c74fc3bd56501b951b48b700f</Sha>
<SourceBuild RepoName="runtime" ManagedOnly="false" />
</Dependency>
<Dependency Name="Microsoft.DotNet.ILCompiler" Version="9.0.0-rc.1.24410.5">
<Uri>https://github.com/dotnet/runtime</Uri>
<Sha>7cb32e193a55a95c74fc3bd56501b951b48b700f</Sha>
</Dependency>
<Dependency Name="System.Reflection.Metadata" Version="9.0.0-rc.1.24410.5">
<Uri>https://github.com/dotnet/runtime</Uri>
<Sha>7cb32e193a55a95c74fc3bd56501b951b48b700f</Sha>
Expand Down
2 changes: 0 additions & 2 deletions eng/Versions.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,8 +212,6 @@
<MicrosoftPrivateIntellisenseVersion>8.0.0-preview-20230918.1</MicrosoftPrivateIntellisenseVersion>
<!-- Mono Cecil -->
<MicrosoftDotNetCecilVersion>0.11.5-alpha.24419.1</MicrosoftDotNetCecilVersion>
<!-- ILCompiler -->
<MicrosoftDotNetILCompilerVersion>9.0.0-rc.1.24410.5</MicrosoftDotNetILCompilerVersion>
elinor-fung marked this conversation as resolved.
Show resolved Hide resolved
<!-- ICU -->
<MicrosoftNETCoreRuntimeICUTransportVersion>10.0.0-alpha.1.24421.1</MicrosoftNETCoreRuntimeICUTransportVersion>
<!-- MsQuic -->
Expand Down
4 changes: 2 additions & 2 deletions src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@
<PublishReadyToRun Condition="'$(UseNativeAotForComponents)' != 'true'">true</PublishReadyToRun>
<PublishSingleFile Condition="'$(UseNativeAotForComponents)' != 'true'">true</PublishSingleFile>
<PublishTrimmed Condition="'$(UseNativeAotForComponents)' != 'true'">true</PublishTrimmed>
<SuppressGenerateILCompilerExplicitPackageReferenceWarning>true</SuppressGenerateILCompilerExplicitPackageReferenceWarning>
</PropertyGroup>

<ItemGroup Condition="'$(UseNativeAotForComponents)' == 'true'">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to keep this around and condition it on MicrosoftDotNetILCompilerVersion being set. It is likely that we will need to take newer ILC that what's in SDK at some point in future again to take a critical fix temporarily.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(We are on similar plan with Roslyn: We use Roslyn from SDK in steady state, but we may use a newer one temporarily.)

<ItemGroup Condition="'$(UseNativeAotForComponents)' == 'true' and '(MicrosoftDotNetILCompilerVersion)' != ''">
<SuppressGenerateILCompilerExplicitPackageReferenceWarning>true</SuppressGenerateILCompilerExplicitPackageReferenceWarning>

Check failure on line 21 in src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj

View check run for this annotation

Azure Pipelines / runtime (Build tvos-arm64 Release AllSubsets_NativeAOT)

src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj#L21 

src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj(21,5): error MSB4232: (NETCORE_ENGINEERING_TELEMETRY=Restore) Items that are outside Target elements must have one of the following operations: Include, Update, or Remove.  /Users/runner/work/1/s/src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj

Check failure on line 21 in src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj

View check run for this annotation

Azure Pipelines / runtime (Build ios-arm64 Release AllSubsets_NativeAOT)

src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj#L21 

src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj(21,5): error MSB4232: (NETCORE_ENGINEERING_TELEMETRY=Restore) Items that are outside Target elements must have one of the following operations: Include, Update, or Remove.  /Users/runner/work/1/s/src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj

Check failure on line 21 in src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj

View check run for this annotation

Azure Pipelines / runtime (Build osx-x64 Release NativeAOT)

src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj#L21 

src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj(21,5): error MSB4232: (NETCORE_ENGINEERING_TELEMETRY=Restore) Items that are outside Target elements must have one of the following operations: Include, Update, or Remove.  /Users/runner/work/1/s/src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj

Check failure on line 21 in src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj

View check run for this annotation

Azure Pipelines / dotnet-linker-tests (Build osx-x64 release Runtime_Release)

src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj#L21 

src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj(21,5): error MSB4232: (NETCORE_ENGINEERING_TELEMETRY=Restore) Items that are outside Target elements must have one of the following operations: Include, Update, or Remove.  /Users/runner/work/1/s/src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj

Check failure on line 21 in src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj

View check run for this annotation

Azure Pipelines / runtime (Build osx-x64 Debug Libraries_CheckedCoreCLR)

src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj#L21 

src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj(21,5): error MSB4232: (NETCORE_ENGINEERING_TELEMETRY=Restore) Items that are outside Target elements must have one of the following operations: Include, Update, or Remove.  /Users/runner/work/1/s/src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj

Check failure on line 21 in src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj

View check run for this annotation

Azure Pipelines / runtime (Build osx-arm64 Release NativeAOT_Libraries)

src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj#L21 

src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj(21,5): error MSB4232: (NETCORE_ENGINEERING_TELEMETRY=Restore) Items that are outside Target elements must have one of the following operations: Include, Update, or Remove.  /Users/runner/work/1/s/src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj

Check failure on line 21 in src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj

View check run for this annotation

Azure Pipelines / runtime (Build osx-arm64 Debug AllSubsets_CoreCLR)

src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj#L21 

src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj(21,5): error MSB4232: (NETCORE_ENGINEERING_TELEMETRY=Restore) Items that are outside Target elements must have one of the following operations: Include, Update, or Remove.  /Users/runner/work/1/s/src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj

Check failure on line 21 in src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj

View check run for this annotation

Azure Pipelines / runtime (Build osx-arm64 Release NativeAOT)

src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj#L21 

src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj(21,5): error MSB4232: (NETCORE_ENGINEERING_TELEMETRY=Restore) Items that are outside Target elements must have one of the following operations: Include, Update, or Remove.  /Users/runner/work/1/s/src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj

Check failure on line 21 in src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj

View check run for this annotation

Azure Pipelines / runtime (Build osx-x64 Debug CoreCLR_Libraries)

src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj#L21 

src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj(21,5): error MSB4232: (NETCORE_ENGINEERING_TELEMETRY=Restore) Items that are outside Target elements must have one of the following operations: Include, Update, or Remove.  /Users/runner/work/1/s/src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj

Check failure on line 21 in src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj

View check run for this annotation

Azure Pipelines / runtime (Build linux_musl-arm checked CoreCLR_ReleaseLibraries)

src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj#L21 

src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj(21,5): error MSB4232: (NETCORE_ENGINEERING_TELEMETRY=Restore) Items that are outside Target elements must have one of the following operations: Include, Update, or Remove.  /__w/1/s/src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj

Check failure on line 21 in src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj

View check run for this annotation

Azure Pipelines / runtime (Build linux-arm Debug AllSubsets_CoreCLR_ReleaseRuntimeLibs)

src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj#L21 

src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj(21,5): error MSB4232: (NETCORE_ENGINEERING_TELEMETRY=Restore) Items that are outside Target elements must have one of the following operations: Include, Update, or Remove.  /__w/1/s/src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj

Check failure on line 21 in src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj

View check run for this annotation

Azure Pipelines / runtime (Build linux-arm64 Release NativeAOT)

src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj#L21 

src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj(21,5): error MSB4232: (NETCORE_ENGINEERING_TELEMETRY=Restore) Items that are outside Target elements must have one of the following operations: Include, Update, or Remove.  /__w/1/s/src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj

Check failure on line 21 in src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj

View check run for this annotation

Azure Pipelines / runtime (Build linux-x64 Release NativeAOT)

src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj#L21 

src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj(21,5): error MSB4232: (NETCORE_ENGINEERING_TELEMETRY=Restore) Items that are outside Target elements must have one of the following operations: Include, Update, or Remove.  /__w/1/s/src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj

Check failure on line 21 in src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj

View check run for this annotation

Azure Pipelines / runtime (Build linux_musl-x64 Debug AllSubsets_CoreCLR)

src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj#L21 

src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj(21,5): error MSB4232: (NETCORE_ENGINEERING_TELEMETRY=Restore) Items that are outside Target elements must have one of the following operations: Include, Update, or Remove.  /__w/1/s/src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj

Check failure on line 21 in src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj

View check run for this annotation

Azure Pipelines / runtime (Build linux-x64 checked CoreCLR_ReleaseLibraries)

src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj#L21 

src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj(21,5): error MSB4232: (NETCORE_ENGINEERING_TELEMETRY=Restore) Items that are outside Target elements must have one of the following operations: Include, Update, or Remove.  /__w/1/s/src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj

Check failure on line 21 in src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj

View check run for this annotation

Azure Pipelines / runtime (Build linux-x64 Debug Libraries_CheckedCoreCLR)

src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj#L21 

src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj(21,5): error MSB4232: (NETCORE_ENGINEERING_TELEMETRY=Restore) Items that are outside Target elements must have one of the following operations: Include, Update, or Remove.  /__w/1/s/src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj

Check failure on line 21 in src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj

View check run for this annotation

Azure Pipelines / runtime (Build linux-x64 Debug CoreCLR_Libraries)

src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj#L21 

src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj(21,5): error MSB4232: (NETCORE_ENGINEERING_TELEMETRY=Restore) Items that are outside Target elements must have one of the following operations: Include, Update, or Remove.  /__w/1/s/src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj

Check failure on line 21 in src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj

View check run for this annotation

Azure Pipelines / runtime (Build linux_musl-x64 Debug CoreCLR_Libraries)

src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj#L21 

src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj(21,5): error MSB4232: (NETCORE_ENGINEERING_TELEMETRY=Restore) Items that are outside Target elements must have one of the following operations: Include, Update, or Remove.  /__w/1/s/src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj

Check failure on line 21 in src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj

View check run for this annotation

Azure Pipelines / runtime (Build linux-x64 checked CLR_Tools_Tests)

src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj#L21 

src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj(21,5): error MSB4232: (NETCORE_ENGINEERING_TELEMETRY=Restore) Items that are outside Target elements must have one of the following operations: Include, Update, or Remove.  /__w/1/s/src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj

Check failure on line 21 in src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj

View check run for this annotation

Azure Pipelines / runtime (Build linux-arm64 Release NativeAOT_Libraries)

src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj#L21 

src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj(21,5): error MSB4232: (NETCORE_ENGINEERING_TELEMETRY=Restore) Items that are outside Target elements must have one of the following operations: Include, Update, or Remove.  /__w/1/s/src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj

Check failure on line 21 in src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj

View check run for this annotation

Azure Pipelines / runtime (Build linux-arm checked CoreCLR_ReleaseLibraries)

src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj#L21 

src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj(21,5): error MSB4232: (NETCORE_ENGINEERING_TELEMETRY=Restore) Items that are outside Target elements must have one of the following operations: Include, Update, or Remove.  /__w/1/s/src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj

Check failure on line 21 in src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj

View check run for this annotation

Azure Pipelines / runtime (Build linux_musl-arm Debug AllSubsets_CoreCLR_ReleaseRuntimeLibs)

src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj#L21 

src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj(21,5): error MSB4232: (NETCORE_ENGINEERING_TELEMETRY=Restore) Items that are outside Target elements must have one of the following operations: Include, Update, or Remove.  /__w/1/s/src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj

Check failure on line 21 in src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj

View check run for this annotation

Azure Pipelines / runtime (Build linux-x64 Debug NativeAOT)

src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj#L21 

src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj(21,5): error MSB4232: (NETCORE_ENGINEERING_TELEMETRY=Restore) Items that are outside Target elements must have one of the following operations: Include, Update, or Remove.  /__w/1/s/src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj

Check failure on line 21 in src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj

View check run for this annotation

Azure Pipelines / runtime (Build linux-arm64 Debug AllSubsets_CoreCLR)

src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj#L21 

src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj(21,5): error MSB4232: (NETCORE_ENGINEERING_TELEMETRY=Restore) Items that are outside Target elements must have one of the following operations: Include, Update, or Remove.  /__w/1/s/src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj

Check failure on line 21 in src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj

View check run for this annotation

Azure Pipelines / runtime (Build linux_musl-arm64 checked CoreCLR_ReleaseLibraries)

src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj#L21 

src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj(21,5): error MSB4232: (NETCORE_ENGINEERING_TELEMETRY=Restore) Items that are outside Target elements must have one of the following operations: Include, Update, or Remove.  /__w/1/s/src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj

Check failure on line 21 in src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj

View check run for this annotation

Azure Pipelines / runtime (Build linux_musl-x64 Debug Libraries_CheckedCoreCLR)

src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj#L21 

src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj(21,5): error MSB4232: (NETCORE_ENGINEERING_TELEMETRY=Restore) Items that are outside Target elements must have one of the following operations: Include, Update, or Remove.  /__w/1/s/src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj

Check failure on line 21 in src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj

View check run for this annotation

Azure Pipelines / runtime (Build linux_musl-arm64 Debug AllSubsets_CoreCLR_ReleaseRuntimeLibs)

src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj#L21 

src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj(21,5): error MSB4232: (NETCORE_ENGINEERING_TELEMETRY=Restore) Items that are outside Target elements must have one of the following operations: Include, Update, or Remove.  /__w/1/s/src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj

Check failure on line 21 in src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj

View check run for this annotation

Azure Pipelines / runtime (Build linux-arm64 Debug Libraries_CheckedCoreCLR)

src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj#L21 

src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj(21,5): error MSB4232: (NETCORE_ENGINEERING_TELEMETRY=Restore) Items that are outside Target elements must have one of the following operations: Include, Update, or Remove.  /__w/1/s/src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj

Check failure on line 21 in src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj

View check run for this annotation

Azure Pipelines / runtime (Build freebsd-x64 Debug CoreCLR)

src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj#L21 

src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj(21,5): error MSB4232: (NETCORE_ENGINEERING_TELEMETRY=Restore) Items that are outside Target elements must have one of the following operations: Include, Update, or Remove.  /__w/1/s/src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj

Check failure on line 21 in src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj

View check run for this annotation

Azure Pipelines / dotnet-linker-tests (Build linux-x64 release Runtime_Release)

src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj#L21 

src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj(21,5): error MSB4232: (NETCORE_ENGINEERING_TELEMETRY=Restore) Items that are outside Target elements must have one of the following operations: Include, Update, or Remove.  /__w/1/s/src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj

Check failure on line 21 in src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj

View check run for this annotation

Azure Pipelines / dotnet-linker-tests

src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj#L21 

src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj(21,5): error MSB4232: (NETCORE_ENGINEERING_TELEMETRY=Restore) Items that are outside Target elements must have one of the following operations: Include, Update, or Remove.  /Users/runner/work/1/s/src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj

Check failure on line 21 in src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj

View check run for this annotation

Azure Pipelines / dotnet-linker-tests

src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj#L21 

src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj(21,5): error MSB4232: (NETCORE_ENGINEERING_TELEMETRY=Restore) Items that are outside Target elements must have one of the following operations: Include, Update, or Remove.  /__w/1/s/src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj

Check failure on line 21 in src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj

View check run for this annotation

Azure Pipelines / runtime

src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj#L21 

src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj(21,5): error MSB4232: (NETCORE_ENGINEERING_TELEMETRY=Restore) Items that are outside Target elements must have one of the following operations: Include, Update, or Remove.  /Users/runner/work/1/s/src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj

Check failure on line 21 in src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj

View check run for this annotation

Azure Pipelines / runtime

src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj#L21 

src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj(21,5): error MSB4232: (NETCORE_ENGINEERING_TELEMETRY=Restore) Items that are outside Target elements must have one of the following operations: Include, Update, or Remove.  /Users/runner/work/1/s/src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj

Check failure on line 21 in src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj

View check run for this annotation

Azure Pipelines / runtime

src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj#L21 

src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj(21,5): error MSB4232: (NETCORE_ENGINEERING_TELEMETRY=Restore) Items that are outside Target elements must have one of the following operations: Include, Update, or Remove.  /Users/runner/work/1/s/src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj

Check failure on line 21 in src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj

View check run for this annotation

Azure Pipelines / runtime

src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj#L21 

src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj(21,5): error MSB4232: (NETCORE_ENGINEERING_TELEMETRY=Restore) Items that are outside Target elements must have one of the following operations: Include, Update, or Remove.  /Users/runner/work/1/s/src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj
jkotas marked this conversation as resolved.
Show resolved Hide resolved
<PackageReference Include="Microsoft.DotNet.ILCompiler" Version="$(MicrosoftDotNetILCompilerVersion)" />
<PackageReference Include="runtime.$(ToolsRID).Microsoft.DotNet.ILCompiler" Version="$(MicrosoftDotNetILCompilerVersion)" />
</ItemGroup>
Expand Down
6 changes: 0 additions & 6 deletions src/native/managed/native-library.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
the same way as eng/native/functions.cmake strip_symbols
-->
<StripSymbols>false</StripSymbols>
<SuppressGenerateILCompilerExplicitPackageReferenceWarning>true</SuppressGenerateILCompilerExplicitPackageReferenceWarning>
<ControlFlowGuard>Guard</ControlFlowGuard>
</PropertyGroup>

Expand Down Expand Up @@ -34,9 +33,4 @@
<!-- passed by compile-native.proj to set - -gcc-toolchain=$(ROOTFS_DIR)/usr -->
<CustomLinkerArg Condition="'$(CustomLinkerArgToolchainArg)' != ''" Include="$(CustomLinkerArgToolchainArg)" />
</ItemGroup>

<ItemGroup>
jkotas marked this conversation as resolved.
Show resolved Hide resolved
<PackageReference Include="Microsoft.DotNet.ILCompiler" Version="$(MicrosoftDotNetILCompilerVersion)" />
<PackageReference Include="runtime.$(ToolsRID).Microsoft.DotNet.ILCompiler" Version="$(MicrosoftDotNetILCompilerVersion)" />
</ItemGroup>
</Project>
Loading