-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arm: Free up upper-half register that was not ready because of its association with busy lower-half register #107714
Conversation
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
@dotnet/jit-contrib @AndyAyersMS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you could run fuzzlyn on this PR?
yes, thanks for reminding. Wanted to run after CI is green, but forgot. |
/azp run Fuzzlyn |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run Antigen |
Azure Pipelines successfully started running 1 pipeline(s). |
No Fuzzlyn failures on linux/arm |
…sociation with busy lower-half register (dotnet#107714) * make sure the upperHalf is moved to ready pool when lowerHalf holding DOUBLE interval is done * remove the logging * added test cases * fix a typo * Add missing Xunit reference * Revert "remove the logging" This reverts commit d8f2f17. * better fix to free up upperHalf if lowerHalf is getting freed up * jit format * Revert "remove the logging" This reverts commit d8f2f17. * Handle upperHalf fix similar to lowerHalf code * formatting * jit format
…sociation with busy lower-half register (dotnet#107714) * make sure the upperHalf is moved to ready pool when lowerHalf holding DOUBLE interval is done * remove the logging * added test cases * fix a typo * Add missing Xunit reference * Revert "remove the logging" This reverts commit d8f2f17. * better fix to free up upperHalf if lowerHalf is getting freed up * jit format * Revert "remove the logging" This reverts commit d8f2f17. * Handle upperHalf fix similar to lowerHalf code * formatting * jit format
With #107493, we were not releasing the upper half register from getting resolved, which was held back due to the fact that the lower half was occupied by a
TYP_DOUBLE
interval. However, when we free up the lower half, we should also mark the upper-half target as ready for resolution.Fixes: ##107621