Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NativeAOT Thread Name #107943

Merged
merged 3 commits into from
Sep 29, 2024
Merged

NativeAOT Thread Name #107943

merged 3 commits into from
Sep 29, 2024

Conversation

cshung
Copy link
Member

@cshung cshung commented Sep 17, 2024

No description provided.

@cshung cshung marked this pull request as draft September 17, 2024 18:55
@build-analysis build-analysis bot mentioned this pull request Sep 17, 2024
Open
3 tasks
@cshung cshung marked this pull request as ready for review September 25, 2024 02:33
@cshung cshung force-pushed the public/set-thread-name branch 3 times, most recently from 9e3dd91 to 746f9d0 Compare September 27, 2024 19:01
@build-analysis build-analysis bot mentioned this pull request Sep 28, 2024
Open
3 tasks
jkotas
jkotas reviewed Sep 29, 2024
View reviewed changes
src/coreclr/System.Private.CoreLib/src/System/Threading/Thread.CoreCLR.cs Outdated Show resolved Hide resolved
src/coreclr/nativeaot/System.Private.CoreLib/src/System/Threading/Thread.NativeAot.cs Outdated Show resolved Hide resolved
src/mono/System.Private.CoreLib/src/System/Threading/Thread.Mono.cs Outdated Show resolved Hide resolved
src/coreclr/nativeaot/Runtime/unix/PalRedhawkUnix.cpp Outdated Show resolved Hide resolved
src/coreclr/nativeaot/Runtime/unix/PalRedhawkUnix.cpp Outdated Show resolved Hide resolved
src/coreclr/nativeaot/System.Private.CoreLib/src/System/Threading/Thread.NativeAot.cs Outdated Show resolved Hide resolved
src/coreclr/nativeaot/System.Private.CoreLib/src/System/Runtime/RuntimeImports.cs Outdated Show resolved Hide resolved
src/coreclr/nativeaot/Runtime/PalRedhawk.h Show resolved Hide resolved
src/coreclr/nativeaot/Runtime/thread.cpp Outdated Show resolved Hide resolved
src/coreclr/nativeaot/Runtime/windows/PalRedhawkMinWin.cpp Outdated Show resolved Hide resolved
This was referenced Sep 29, 2024
Open
Open
Open
@build-analysis build-analysis bot mentioned this pull request Sep 29, 2024
Open
3 tasks
am11
am11 reviewed Sep 29, 2024
View reviewed changes
src/coreclr/vm/gcenv.ee.cpp
@@ -1512,6 +1528,10 @@ namespace
ThreadStubArguments* args = static_cast<ThreadStubArguments*>(argument);
assert(args != nullptr);

#ifdef __APPLE__
SetThreadName(GetCurrentThread(), args->name);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cshung, I think we can use it on all targets #108370?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cshung, I think we can use it on all targets #108370?

Yes we can, but that would just be extra work since for all other platforms we have already set the name earlier.

jkotas
jkotas approved these changes Sep 29, 2024
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@build-analysis build-analysis bot mentioned this pull request Sep 29, 2024
Open
3 tasks
@jkotas jkotas merged commit 2917e51 into dotnet:main Sep 29, 2024
147 of 151 checks passed
@cshung cshung deleted the public/set-thread-name branch September 29, 2024 22:14
sirntar pushed a commit to sirntar/runtime that referenced this pull request Sep 30, 2024
@cshung @jkotas @sirntar
NativeAOT Thread Name (dotnet#107943)
a4eba69 
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@am11 am11 am11 left review comments

@hez2010 hez2010 hez2010 left review comments

@jkotas jkotas jkotas approved these changes

@MichalStrehovsky MichalStrehovsky Awaiting requested review from MichalStrehovsky MichalStrehovsky is a code owner

@marek-safar marek-safar Awaiting requested review from marek-safar marek-safar is a code owner

Assignees

@cshung cshung

Labels
area-NativeAOT-coreclr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cshung @am11 @jkotas @hez2010