guard agains empty Accept address #108334
Open
+3
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/ncl |
3 tasks
|
/backport to main |
|
Started backporting to main: https://github.com/dotnet/runtime/actions/runs/11221178118 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
contributes to #108026 and #102663
This is a speculative fix based on feedback from @pepone.
It seems like in some cases
accepton macOS does not return valid peer address and we throw on background thread.This adds some guarding agains that to prevent thread termination.
I don't think workaround from #102663 (comment) is needed.
We already call
getpeernameifRemoteEndPointis accessed and remote address is not available. It seems like we do not need it for anything else inCreateAcceptSocketand descendants.