Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mono]Re-enable runtime tests on Android arm64 #49662

Merged
merged 14 commits into from
Jun 22, 2021

Conversation

fanyang-mono
Copy link
Member

@fanyang-mono fanyang-mono commented Mar 15, 2021

Fixes #45568 Fixes #47850

Before this PR, there were only 475 runtime tests running on Android arm64 and it took more than 3 hours to run those tests. With this PR, there are 2,429 runtime tests running on Android arm64 now and it takes around 1 hour to run them.

Tests to only run on rolling build, since there aren't enough Android devices.

@ghost
Copy link

ghost commented Mar 15, 2021

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details
Author: fanyang-mono
Assignees: -
Labels:

area-Infrastructure-mono

Milestone: -

@ghost
Copy link

ghost commented Apr 14, 2021

Draft Pull Request was automatically closed for inactivity. It can be manually reopened in the next 30 days if the work resumes.

@fanyang-mono fanyang-mono reopened this May 4, 2021
@fanyang-mono fanyang-mono force-pushed the android_runtime_tests branch 2 times, most recently from b545a82 to 1ecc87b Compare May 8, 2021 03:07
@fanyang-mono fanyang-mono force-pushed the android_runtime_tests branch 3 times, most recently from e450b71 to 773316c Compare May 14, 2021 18:13
@fanyang-mono fanyang-mono force-pushed the android_runtime_tests branch 2 times, most recently from 5bad1fe to e8a4ecd Compare May 24, 2021 15:54
@fanyang-mono
Copy link
Member Author

Waiting for dotnet/xharness#610 for further investigation of the timeout issue.

@fanyang-mono fanyang-mono force-pushed the android_runtime_tests branch 3 times, most recently from 19fdcc0 to 1ea6594 Compare June 4, 2021 11:07
@fanyang-mono
Copy link
Member Author

Waiting for dotnet/xharness#610 for further investigation of the timeout issue.

This issue was not related to this PR any more.

@fanyang-mono
Copy link
Member Author

Failure of workitem PayloadGroup0 was due to a known issue #11063

System.InvalidOperationException: Collection was modified after the enumerator was instantiated.
   at System.Collections.Generic.Stack`1.Enumerator.MoveNext() in System.Collections.dll:token 0x6000289+0x0
   at Xunit.Sdk.DisposalTracker.Dispose() in C:\Dev\xunit\xunit\src\xunit.execution\Sdk\DisposalTracker.cs:line 26
   at Xunit.Sdk.ExtensibilityPointFactory.Dispose() in C:\Dev\xunit\xunit\src\xunit.execution\Sdk\ExtensibilityPointFactory.cs:line 53
   at Xunit.Sdk.TestFramework.Dispose() in C:\Dev\xunit\xunit\src\xunit.execution\Sdk\Frameworks\TestFramework.cs:line 52
   at System.Threading.Tasks.Task.<>c.<ThrowAsync>b__140_1(Object state) in System.Private.CoreLib.dll:token 0x6002df5+0x0
   at System.Threading.QueueUserWorkItemCallbackDefaultContext.Execute() in System.Private.CoreLib.dll:token 0x6002b1d+0x14
   at System.Threading.ThreadPoolWorkQueue.Dispatch() in System.Private.CoreLib.dll:token 0x6002af8+0x10a
   at System.Threading.PortableThreadPool.WorkerThread.WorkerThreadStart() in System.Private.CoreLib.dll:token 0x6002bd2+0x6c
   at System.Threading.Thread.StartCallback() in System.Private.CoreLib.dll:token 0x600278e+0xe

@fanyang-mono fanyang-mono changed the title [WIP][mono]Re-enable runtime tests on Android arm64 [mono]Re-enable runtime tests on Android arm64 Jun 18, 2021
@fanyang-mono fanyang-mono marked this pull request as ready for review June 18, 2021 19:23
@SamMonoRT
Copy link
Member

@akoeplinger - what needs to be done to enable these only on rolling builds as we had discussed a few weeks back ?

@fanyang-mono - LGTM - I'll approve, but please confirm with @akoeplinger prior to merging.

@fanyang-mono
Copy link
Member Author

The failures on windows arm64 were irrelevant to this PR. There are two tracking issues for it dotnet/core-eng#13324 and dotnet/core-eng#13292

@fanyang-mono
Copy link
Member Author

I am merging this now. @akoeplinger if there is anything needs to be changed after reviewing, please leave a comment.

@fanyang-mono fanyang-mono merged commit 245dddc into dotnet:main Jun 22, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jul 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants