-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ImageAnimator to render the correct frames #52236
Merged
jeffhandley
merged 11 commits into
dotnet:main
from
jeffhandley:jeffhandley/imageanimator
May 6, 2021
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
fc8c2be
Blend the Windows/Unix implementations of ImageAnimator to fix StopAn…
jeffhandley 5c298b4
Temporarily add animated gifs to the test project (awaiting arcade up…
jeffhandley 6a2f9fc
Rewrite ImageAnimator to render the correct frames
jeffhandley d51deef
Add ImageAnimatorManualTests
jeffhandley 87ffa25
Address PR feedback, including using a StopWatch for the timing
jeffhandley 10c6005
Respect animation loop counts
jeffhandley c431ca7
Limit animation to 4/100ths of a second
jeffhandley 7e94a95
Apply the IsDrawingSupported condition to ImageAnimator tests
jeffhandley 191d77f
Merge branch 'main' into jeffhandley/imageanimator
jeffhandley e4c1fef
Revert "Temporarily add animated gifs to the test project (awaiting a…
jeffhandley d750190
Update manual test comment
jeffhandley File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
194 changes: 0 additions & 194 deletions
194
src/libraries/System.Drawing.Common/src/System/Drawing/ImageAnimator.Unix.cs
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: