Finish migrating RSAOpenSsl from RSA* to EVP_PKEY* #54282
Conversation
|
Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @GrabYourPitchforks Issue DetailsThis change moves the RSAOpenSsl class (and the RSA.Create() internal class on Linux) to use EVP_PKEY A large portion of the code is just from splitting the key helpers files to not need all of the encrypted PKCS#8 support Once PKCS#8 and SPKI became the primary modes of interaction the spanified import and export routines for those got This change completely eliminates SafeRsaHandle, and the only time that an
|
src/libraries/Native/Unix/System.Security.Cryptography.Native/entrypoints.c
Outdated
Show resolved
Hide resolved
src/libraries/Native/Unix/System.Security.Cryptography.Native/apibridge.c
Show resolved
Hide resolved
| int algId); | ||
|
|
||
| internal static unsafe SafeEvpPKeyHandle DecodeSubjectPublicKeyInfo( | ||
| ReadOnlySpan<byte> source, |
There was a problem hiding this comment.
Nit: Since CryptoNative_DecodeSubjectPublicKeyInfo requires buf != nullptr and len > 0, may want a Debug.Assert(!source.IsEmpty); statement here.
(Same comment for related methods in this file.)
| finally | ||
| { | ||
| CryptographicOperations.ZeroMemory(encryptedSpan); | ||
| CryptoPool.Return(encryptedRent!, clearSize: 0); |
There was a problem hiding this comment.
encryptedRent may be null if an exception is thrown on line 203 - 204. I'd recommend moving lines 198 - 206 to be before the try block, which obviates this issue; or putting a null guard around this.
There was a problem hiding this comment.
Since this is just a partial split-out with no changes, and there's a clock running for the preview snap, I'll tackle this across all the algorithms as a followup.
|
Test failure is #55536 |
ghost
locked as resolved and limited conversation to collaborators
This change moves the RSAOpenSsl class (and the RSA.Create() internal class on Linux) to use EVP_PKEY
for the import and export operations, making the interaction with the underlying library based on
PKCS#8 PrivateKeyInfo and X.509 SubjectPublicKeyInfo key blobs.
A large portion of the code is just from splitting the key helpers files to not need all of the encrypted PKCS#8 support
in the System.Security.Cryptography.OpenSsl library, as the encrypted PKCS#8 <-> unencrypted PKCS#8 work provided
by the base classes is sufficient.
Once PKCS#8 and SPKI became the primary modes of interaction the spanified import and export routines for those got
overridden in RSAOpenSsl to avoid SPKI->RSAParameters->SPKI-style conversions.
This change completely eliminates SafeRsaHandle, and the only time that an
RSA*is used at all is in the legacy RSAOpenSsl(IntPtr) constructor.Contributes to #46526.