Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ImmutableArray<T>.Builder.DrainToImmutable() #79385

Merged
merged 3 commits into from
Dec 8, 2022

Conversation

jeffhandley
Copy link
Member

Closes #72625. Approved API details: #72625 (comment).

DrainToImmutable will "do the cheapest thing possible" to return the current contents as an immutable array and then reset the collection to a zero-length array.

@jeffhandley jeffhandley added this to the 8.0.0 milestone Dec 8, 2022
@jeffhandley jeffhandley self-assigned this Dec 8, 2022
@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Dec 8, 2022

Tagging subscribers to this area: @dotnet/area-system-collections
See info in area-owners.md if you want to be subscribed.

Issue Details

Closes #72625. Approved API details: #72625 (comment).

DrainToImmutable will "do the cheapest thing possible" to return the current contents as an immutable array and then reset the collection to a zero-length array.

Author: jeffhandley
Assignees: jeffhandley
Labels:

area-System.Collections

Milestone: 8.0.0

Copy link
Member

@eiriktsarpalis eiriktsarpalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jeffhandley
Copy link
Member Author

@ghost ghost locked as resolved and limited conversation to collaborators Jan 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[API Proposal]: ImmutableArray<T>.Builder.ToImmutableAndClear()
6 participants