Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This fixes emitGetVexPrefixSize to support detecting 2-byte prefix support #79478

Merged
merged 15 commits into from
Dec 14, 2022
Merged

This fixes emitGetVexPrefixSize to support detecting 2-byte prefix support #79478

merged 15 commits into from
Dec 14, 2022

Commits on Dec 9, 2022

  1. Remove the dead emitOutputRexOrVexPrefixIfNeeded and rename emitOutpu… 

    …tSimdPrefixIfNeeded to emitOutputRexOrSimdPrefixIfNeeded
    @tannergooding
    tannergooding committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    ec19c12 View commit details
    Browse the repository at this point in the history

  2. Remove the dead emitGetAdjustedSize and rename emitGetAdjustedSizeEve… 

    …xAware to emitGetAdjustedSize
    @tannergooding
    tannergooding committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    4d75d05 View commit details
    Browse the repository at this point in the history

  3. Simplify the emitGetEvexPrefixSize and emitGetVexPrefixSize methods

    @tannergooding
    tannergooding committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    0932ac1 View commit details
    Browse the repository at this point in the history

  4. Create helper emitExtractVexPrefix and emitExtractEvexPrefix functions

    @tannergooding
    tannergooding committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    7bd14be View commit details
    Browse the repository at this point in the history

  5. Update emitGetVexPrefixSize and emitGetEvexPrefixSize to take an inst… 

    …rDesc
    @tannergooding
    tannergooding committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    b20a6d5 View commit details
    Browse the repository at this point in the history

  6. Update emitGetPrefixSize to take the instrDesc so the VEX prefix size… 

    … can be computed correctly
    @tannergooding
    tannergooding committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    4d94897 View commit details
    Browse the repository at this point in the history

  7. Update emitGetVexPrefixSize to support returning 2 or 3

    @tannergooding
    tannergooding committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    ae744eb View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2022

  1. Ensure IF_RWR_CNS is handled in emitGetVexPrefixSize

    @tannergooding
    tannergooding committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    f2ff3c4 View commit details
    Browse the repository at this point in the history

  2. Don't try to estimate the 2-byte VEX prefix when optimizations are di… 

    …sabled
    @tannergooding
    tannergooding committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    e131b6b View commit details
    Browse the repository at this point in the history

  3. Ensure we don't negatively impact estimated alignment sizes for debug… 

    … code
    @tannergooding
    tannergooding committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    ea56d5f View commit details
    Browse the repository at this point in the history

  4. Just check MinOpts not OptimizationsDisabled

    @tannergooding
    tannergooding committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    5014355 View commit details
    Browse the repository at this point in the history

  5. Mark some of the modified methods as const to indicate they don't mut… 

    …ate the emitter
    @tannergooding
    tannergooding committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    989c1ec View commit details
    Browse the repository at this point in the history

  6. Resolve the throughput issue by not getting optSize untill necessary

    @tannergooding
    tannergooding committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    0f2514d View commit details
    Browse the repository at this point in the history

  7. Switch back to doing accurate vex prefix size estimation always

    @tannergooding
    tannergooding committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    4d0c099 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2022

  1. Small cleanup to reduce regression

    @tannergooding
    tannergooding committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    57d5725 View commit details
    Browse the repository at this point in the history