-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JIT: reset max bbnum after failed inline attempt #80958
Conversation
And if we renumber blocks in the inlinee's portion of the flow graph, start renumbering from the max bbnum before the inline attempt, rather than the current maximum. More prep work in anticipation of moving pred list building to happen before (or the root) and during (for inlinees) inlining.
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak Issue DetailsAnd if we renumber blocks in the inlinee's portion of the flow graph, start renumbering from the max bbnum before the inline attempt, rather than the current maximum. More prep work in anticipation of moving pred list building to happen before (or the root) and during (for inlinees) inlining.
|
More refactoring in preparation for moving pred list building earlier. @EgorBo PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reminds me that normally we almost never inline methods with SWITCHes (only with foldable ones) but in some jitstress mode we do that due to extra multipliers so I think I once hit some BBNum related bug there (and fixed)
Are you politely suggesting that I should run jit stress? |
/azp run runtime-coreclr jitstress, runtime-coreclr libraries-jitstress |
Azure Pipelines successfully started running 2 pipeline(s). |
Building pri1 tests may be broken?
|
Libraries stress hitting an assert, probably something I did recerntly (if not in this PR)
|
Related: Roslyn update in #80850 (partial remediation in #80931) |
When we're not optimizing, |
Merging to pick up the jitstress fix. |
/azp run runtime-coreclr jitstress, runtime-coreclr libraries-jitstress |
Azure Pipelines successfully started running 2 pipeline(s). |
And if we renumber blocks in the inlinee's portion of the flow graph, start renumbering from the max bbnum before the inline attempt, rather than the current maximum. More prep work in anticipation of moving pred list building to happen before (or the root) and during (for inlinees) inlining.
And if we renumber blocks in the inlinee's portion of the flow graph, start renumbering from the max bbnum before the inline attempt, rather than the current maximum.
More prep work in anticipation of moving pred list building to happen before (or the root) and during (for inlinees) inlining.