Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] Webcil-in-WebAssembly #85932

Merged
merged 31 commits into from
May 16, 2023
Merged

[wasm] Webcil-in-WebAssembly #85932

merged 31 commits into from
May 16, 2023

Commits on May 10, 2023

  1. Add option to emit webcil inside a wasm module wrapper

    @lambdageek
    lambdageek committed May 10, 2023
    Configuration menu
    Copy the full SHA
    310aa3e View commit details
    Browse the repository at this point in the history

  2. [mono][loader] implement a webcil-in-wasm reader

    @lambdageek
    lambdageek committed May 10, 2023
    Configuration menu
    Copy the full SHA
    2f2459d View commit details
    Browse the repository at this point in the history

  3. reword WebcilWasmWrapper summary comment

    @lambdageek
    lambdageek committed May 10, 2023
    Configuration menu
    Copy the full SHA
    7be51f8 View commit details
    Browse the repository at this point in the history

  4. fix whitespace

    @lambdageek
    lambdageek committed May 10, 2023
    Configuration menu
    Copy the full SHA
    2e58062 View commit details
    Browse the repository at this point in the history

  5. fix typos

    @lambdageek
    lambdageek committed May 10, 2023
    Configuration menu
    Copy the full SHA
    056b9ac View commit details
    Browse the repository at this point in the history

  6. visit_section should bump the ptr after traversal

    @lambdageek
    lambdageek committed May 10, 2023
    Configuration menu
    Copy the full SHA
    897df89 View commit details
    Browse the repository at this point in the history

  7. remove extra bytes from wasm webcil prefix 

    the split utility was including the data header prefix in the output
    @lambdageek
    lambdageek committed May 10, 2023
    Configuration menu
    Copy the full SHA
    15a1894 View commit details
    Browse the repository at this point in the history

  8. don't forget to include number of segments in the data section

    @lambdageek
    lambdageek committed May 10, 2023
    Configuration menu
    Copy the full SHA
    1688dec View commit details
    Browse the repository at this point in the history

  9. update the Webcil spec to include the WebAssembly wrapper module

    @lambdageek
    lambdageek committed May 10, 2023
    Configuration menu
    Copy the full SHA
    d8638f7 View commit details
    Browse the repository at this point in the history

  10. fix typos and whitespace

    @lambdageek
    lambdageek committed May 10, 2023
    Configuration menu
    Copy the full SHA
    e8f52bb View commit details
    Browse the repository at this point in the history

  11. advance endp past the data segment payload

    @lambdageek
    lambdageek committed May 10, 2023
    Configuration menu
    Copy the full SHA
    f06938f View commit details
    Browse the repository at this point in the history

  12. Adjust RVA map offsets to account for wasm prefix 

    MonoImage:raw_data is used as a base when applying the RVA map to map
virtual addresses to physical offsets in the assembly.  With
webcil-in-wasm there's an extra wasm prefix before the webcil payload
starts, so we need to account for this extra data when creating the
mapping.

An alternative is to compute the correct offsets as part of generating
the webcil, but that would entangle the wasm module and the webcil
payload.  The current (somewhat hacky approach) keeps them
logically separate.
    @lambdageek
    lambdageek committed May 10, 2023
    Configuration menu
    Copy the full SHA
    0f5e02f View commit details
    Browse the repository at this point in the history

  13. Add a note about the rva mapping to the spec

    @lambdageek
    lambdageek committed May 10, 2023
    Configuration menu
    Copy the full SHA
    4271d8f View commit details
    Browse the repository at this point in the history

  14. Serve webcil-in-wasm as .wasm

    @lambdageek
    lambdageek committed May 10, 2023
    Configuration menu
    Copy the full SHA
    2c90fb5 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2023

  1. fix wbt

    @lambdageek
    lambdageek committed May 11, 2023
    Configuration menu
    Copy the full SHA
    307ae9a View commit details
    Browse the repository at this point in the history

  2. remove old .webcil support from Sdk Pack Tasks

    @lambdageek
    lambdageek committed May 11, 2023
    Configuration menu
    Copy the full SHA
    930cfeb View commit details
    Browse the repository at this point in the history

  3. Set SelfContained=true for browser-wasm runtimes (dotnet#86102)

    @lewing @lambdageek
    lewing authored and lambdageek committed May 11, 2023
    Configuration menu
    Copy the full SHA
    7670b3c View commit details
    Browse the repository at this point in the history

  4. Implement support for webcil in wasm in the managed WebcilReader

    @lambdageek
    lambdageek committed May 11, 2023
    Configuration menu
    Copy the full SHA
    d17b8dd View commit details
    Browse the repository at this point in the history

Commits on May 12, 2023

  1. why fail?

    @lambdageek
    lambdageek committed May 12, 2023
    Configuration menu
    Copy the full SHA
    61afae7 View commit details
    Browse the repository at this point in the history

  2. did we load the same asm twice??

    @lambdageek
    lambdageek committed May 12, 2023
    Configuration menu
    Copy the full SHA
    8a42b70 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2023

  1. Merge remote-tracking branch 'origin/main' into webcil-wasm-wrapper

    @lambdageek
    lambdageek committed May 15, 2023
    Configuration menu
    Copy the full SHA
    ccd074e View commit details
    Browse the repository at this point in the history

  2. checkpoint. things are broken. but I adjusted MonoImage:raw_data

    @lambdageek
    lambdageek committed May 15, 2023
    Configuration menu
    Copy the full SHA
    6166a67 View commit details
    Browse the repository at this point in the history

  3. align webcil payload to a 4-byte boundary within the wasm module 

    Add padding to data segment 0 to ensure that data segment 1's
payload (ie the webcil content itself) is 4-byte aligned
    @lambdageek
    lambdageek committed May 15, 2023
    Configuration menu
    Copy the full SHA
    eedf447 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2023

  1. remove WIP tracing

    @lambdageek
    lambdageek committed May 16, 2023
    Configuration menu
    Copy the full SHA
    d9b396e View commit details
    Browse the repository at this point in the history

  2. assert that webcil raw data is 4-byte aligned

    @lambdageek
    lambdageek committed May 16, 2023
    Configuration menu
    Copy the full SHA
    89ef589 View commit details
    Browse the repository at this point in the history

  3. revert unrelated build change

    @lambdageek
    lambdageek committed May 16, 2023
    Configuration menu
    Copy the full SHA
    d9a3fea View commit details
    Browse the repository at this point in the history

  4. revert unrelated change

    @lambdageek
    lambdageek committed May 16, 2023
    Configuration menu
    Copy the full SHA
    6de7dee View commit details
    Browse the repository at this point in the history

  5. revert whitespace

    @lambdageek
    lambdageek committed May 16, 2023
    Configuration menu
    Copy the full SHA
    88f956e View commit details
    Browse the repository at this point in the history

  6. revert WBT debugging output changes

    @lambdageek
    lambdageek committed May 16, 2023
    Configuration menu
    Copy the full SHA
    0542c51 View commit details
    Browse the repository at this point in the history

  7. add 4-byte alignment requirement to the webcil spec

    @lambdageek
    lambdageek committed May 16, 2023
    Configuration menu
    Copy the full SHA
    7c0643d View commit details
    Browse the repository at this point in the history

  8. Don't modify MonoImageStorage:raw_data 

    instead just keep track of the webcil offset in the MonoImageStorage.

This introduces a situation where MonoImage:raw_data is different from
MonoImageStorage:raw_data.  The one to use for accessing IL and
metadata is MonoImage:raw_data.

The storage pointer is just used by the image loading machinery
    @lambdageek
    lambdageek committed May 16, 2023
    Configuration menu
    Copy the full SHA
    e187b00 View commit details
    Browse the repository at this point in the history