-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove uses of SR.GetResourceString throughout the libs #87912
Conversation
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsFixes #81338. Cc @dotnet/ilc-contrib @stephentoub
|
src/libraries/System.Transactions.Local/src/System/Transactions/Oletx/OletxTransaction.cs
Show resolved
Hide resolved
src/libraries/System.Text.Encoding.CodePages/src/System/Text/BaseCodePageEncoding.netcoreapp.cs
Show resolved
Hide resolved
src/libraries/Microsoft.Extensions.Primitives/src/ThrowHelper.cs
Outdated
Show resolved
Hide resolved
...ibraries/System.ComponentModel.TypeConverter/src/System/Timers/TimersDescriptionAttribute.cs
Outdated
Show resolved
Hide resolved
Do we want to use the BannedApiAnalyzer to make sure that we don't re-add usages of |
The API is private so the chances are pretty low I think (someone would have to make it public/internal and ignore the comment right above). |
Fixes #81338.
Cc @dotnet/ilc-contrib @stephentoub