Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NativeAOT rethrow bug #88113

Merged
merged 4 commits into from
Jun 29, 2023
Merged

Conversation

janvorli
Copy link
Member

@janvorli janvorli commented Jun 27, 2023

The rethrowing incorrectly starts searching for exception clause based on the previously searched clause for the exception being rethrown. It should always start from the beginning.

Close #88128

The rethrowing incorrectly starts searching for exception clause based
on the previously searched clause for the exception being rethrown. It
should always start from the beginning.
@janvorli janvorli added NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) NO-REVIEW Experimental/testing PR, do NOT review it area-NativeAOT-coreclr labels Jun 27, 2023
@janvorli janvorli added this to the 8.0.0 milestone Jun 27, 2023
@janvorli janvorli self-assigned this Jun 27, 2023
@ghost
Copy link

ghost commented Jun 28, 2023

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

The rethrowing incorrectly starts searching for exception clause based on the previously searched clause for the exception being rethrown. It should always start from the beginning.

Author: janvorli
Assignees: janvorli
Labels:

NO-MERGE, NO-REVIEW, area-NativeAOT-coreclr

Milestone: 8.0.0

@janvorli janvorli removed NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) NO-REVIEW Experimental/testing PR, do NOT review it labels Jun 28, 2023
@janvorli janvorli requested a review from jkotas June 28, 2023 11:20
@janvorli
Copy link
Member Author

/azp run runtime-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jkotas
Copy link
Member

jkotas commented Jun 28, 2023

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@jkotas jkotas merged commit 8899ed4 into dotnet:main Jun 29, 2023
113 of 116 checks passed
@ghost ghost locked as resolved and limited conversation to collaborators Jul 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NativeAOT fails to catch rethrown exception in edge cases
2 participants