Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mono] UnsafeAccessorAttribute non-generic support for field #88626

Merged
merged 35 commits into from
Jul 14, 2023
Merged

[Mono] UnsafeAccessorAttribute non-generic support for field #88626

merged 35 commits into from
Jul 14, 2023

Commits on Jul 5, 2023

  1. Detect an UnsafeAccessorAttribute for method with interpreter

    @fanyang-mono
    fanyang-mono committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    bc9d6ed View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2023

  1. Change field to property

    @fanyang-mono
    fanyang-mono committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    1643710 View commit details
    Browse the repository at this point in the history

  2. Get Kind from typed_args

    @fanyang-mono
    fanyang-mono committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    b0def6c View commit details
    Browse the repository at this point in the history

  3. define MonoUnsafeAccessorKind enum

    @lambdageek @fanyang-mono
    lambdageek authored and fanyang-mono committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    0c51e8a View commit details
    Browse the repository at this point in the history

  4. Add the frontend for JIT

    @fanyang-mono
    fanyang-mono committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    94ce7d2 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2023

  1. Add mono_marshal_get_unsafe_accessor_wrapper and WRAPPER_SUBTYPE_UNSA… 

    …FE_ACCESSOR

And the associated AOT compiler/runtime and marshaling caching boilerplate.
    @lambdageek @fanyang-mono
    lambdageek authored and fanyang-mono committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    a49a8e0 View commit details
    Browse the repository at this point in the history

  2. [interp] get the unsafe accessor wrapper

    @lambdageek @fanyang-mono
    lambdageek authored and fanyang-mono committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    4701689 View commit details
    Browse the repository at this point in the history

  3. fix: skip visibility in unsafe accessor wrappers 

    that is the whole point of them
    @lambdageek @fanyang-mono
    lambdageek authored and fanyang-mono committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    495ce38 View commit details
    Browse the repository at this point in the history

  4. fix: decode the length and copy the name from UnsafeAccessorAttribute 

    The name has a length as a prefix and doesn not have a null terminator
    @lambdageek @fanyang-mono
    lambdageek authored and fanyang-mono committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    35c4d45 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2023

  1. [mini] compile wrapper

    @lambdageek @fanyang-mono
    lambdageek authored and fanyang-mono committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    0c8f4da View commit details
    Browse the repository at this point in the history

  2. [aot] Emit unsafe accessor wrappers to the AOT image

    @lambdageek @fanyang-mono
    lambdageek authored and fanyang-mono committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    8d039e6 View commit details
    Browse the repository at this point in the history

  3. Add the method to emit wrapper for field

    @fanyang-mono
    fanyang-mono committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    080559a View commit details
    Browse the repository at this point in the history

  4. Fix typo

    @fanyang-mono
    fanyang-mono committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    2ec266b View commit details
    Browse the repository at this point in the history

  5. Remove assertion for interpreter

    @fanyang-mono
    fanyang-mono committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    8571969 View commit details
    Browse the repository at this point in the history

  6. Fix format and replace assertion with proper exception

    @fanyang-mono
    fanyang-mono committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    b7e35c6 View commit details
    Browse the repository at this point in the history

  7. Free the memory and throw proper NotImplementedException

    @fanyang-mono
    fanyang-mono committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    449aa6f View commit details
    Browse the repository at this point in the history

  8. Enable StaticField and Field tests

    @fanyang-mono
    fanyang-mono committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    da84576 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2023

  1. Remove unused variables

    @fanyang-mono
    fanyang-mono committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    23a4d9a View commit details
    Browse the repository at this point in the history

  2. Only allow static method

    @fanyang-mono
    fanyang-mono committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    342c8d4 View commit details
    Browse the repository at this point in the history

  3. Return immediately once hit an exception

    @fanyang-mono
    fanyang-mono committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    375d460 View commit details
    Browse the repository at this point in the history

  4. Free cinfo at the right location

    @fanyang-mono
    fanyang-mono committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    9222fd2 View commit details
    Browse the repository at this point in the history

  5. Disable test, cause Constructor kind is not supported yet.

    @fanyang-mono
    fanyang-mono committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    ab2e8c5 View commit details
    Browse the repository at this point in the history

  6. Stop inlining UnsafeAccessor wrapper for interpreter

    @fanyang-mono
    fanyang-mono committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    2f8031a View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2023

  1. Merge branch 'main' into unsafeAccessor

    @fanyang-mono
    fanyang-mono committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    10e43de View commit details
    Browse the repository at this point in the history

  2. Revert inlining change

    @fanyang-mono
    fanyang-mono committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    4d874c3 View commit details
    Browse the repository at this point in the history

  3. Update exception message

    @fanyang-mono
    fanyang-mono committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    ade7c78 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2023

  1. Fix loading static field and add static status check and a test

    @fanyang-mono
    fanyang-mono committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    58822ca View commit details
    Browse the repository at this point in the history

  2. Add another test and address feedback

    @fanyang-mono
    fanyang-mono committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    3686590 View commit details
    Browse the repository at this point in the history

  3. Update src/tests/baseservices/compilerservices/UnsafeAccessors/Unsafe… 

    …AccessorsTests.cs

Co-authored-by: Aaron Robinson <arobins@microsoft.com>
    @fanyang-mono @AaronRobinsonMSFT
    fanyang-mono and AaronRobinsonMSFT authored Jul 13, 2023
    Configuration menu
    Copy the full SHA
    8afb00a View commit details
    Browse the repository at this point in the history

  4. Update src/tests/baseservices/compilerservices/UnsafeAccessors/Unsafe… 

    …AccessorsTests.cs

Co-authored-by: Aaron Robinson <arobins@microsoft.com>
    @fanyang-mono @AaronRobinsonMSFT
    fanyang-mono and AaronRobinsonMSFT authored Jul 13, 2023
    Configuration menu
    Copy the full SHA
    a3f9e77 View commit details
    Browse the repository at this point in the history

  5. Update src/tests/baseservices/compilerservices/UnsafeAccessors/Unsafe… 

    …AccessorsTests.cs

Co-authored-by: Aaron Robinson <arobins@microsoft.com>
    @fanyang-mono @AaronRobinsonMSFT
    fanyang-mono and AaronRobinsonMSFT authored Jul 13, 2023
    Configuration menu
    Copy the full SHA
    9f6b532 View commit details
    Browse the repository at this point in the history

  6. Update src/tests/baseservices/compilerservices/UnsafeAccessors/Unsafe… 

    …AccessorsTests.cs

Co-authored-by: Aaron Robinson <arobins@microsoft.com>
    @fanyang-mono @AaronRobinsonMSFT
    fanyang-mono and AaronRobinsonMSFT authored Jul 13, 2023
    Configuration menu
    Copy the full SHA
    0c15ccd View commit details
    Browse the repository at this point in the history

  7. Update src/tests/baseservices/compilerservices/UnsafeAccessors/Unsafe… 

    …AccessorsTests.cs

Co-authored-by: Aaron Robinson <arobins@microsoft.com>
    @fanyang-mono @AaronRobinsonMSFT
    fanyang-mono and AaronRobinsonMSFT authored Jul 13, 2023
    Configuration menu
    Copy the full SHA
    f21b78e View commit details
    Browse the repository at this point in the history

  8. Address more review feedback

    @fanyang-mono
    fanyang-mono committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    781f512 View commit details
    Browse the repository at this point in the history

  9. Fix function call to field

    @fanyang-mono
    fanyang-mono committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    17febef View commit details
    Browse the repository at this point in the history