Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mono][mini] Fix conversion from STACK_PTR to R8 #88745

Merged
merged 2 commits into from
Jul 12, 2023

Conversation

BrzVlad
Copy link
Member

@BrzVlad BrzVlad commented Jul 12, 2023

It was hardcoded to int conversion instead of checking the arch ptr size.

Fixes #69795

It was hardcoded to int conversion instead of checking the arch ptr size.
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jul 12, 2023
@ghost ghost assigned BrzVlad Jul 12, 2023
@BrzVlad BrzVlad added area-Codegen-JIT-mono and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jul 12, 2023
@lewing
Copy link
Member

lewing commented Jul 12, 2023

wbt failures are #88751

@lewing lewing merged commit 11fbd15 into dotnet:main Jul 12, 2023
127 of 132 checks passed
@ghost ghost locked as resolved and limited conversation to collaborators Aug 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mono incorrectly handles floating-point conversions on 64-bit
3 participants