Support invoke of function pointer type arg #90270
Conversation
|
Tagging subscribers to this area: @dotnet/area-system-reflection Issue Details[verifying tests]
|
steveharter
force-pushed
the
FcnPtrFix
branch
2 times, most recently
from
a41e446
to
86cb0eb
Compare
steveharter
requested review from
MichalStrehovsky,
buyaa-n,
jkotas and
ivanpovazan
src/coreclr/System.Private.CoreLib/src/System/RuntimeType.CoreCLR.cs
Outdated
Show resolved
Hide resolved
|
Is this planned to be merged in by RC1 snap? |
I'll hold off on this PR until the Mono function pointer introspection PR is in. |
Thank you. Done! |
steveharter
requested review from
vargaz,
lambdageek,
SamMonoRT and
thaystg
as code owners
|
The mono changes look ok. |
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| @@ -838,6 +838,11 @@ private unsafe object ReturnTransform(ref byte byref, bool wrapInTargetInvocatio | |||
| Debug.Assert(type.IsPointer); | |||
| obj = Pointer.Box((void*)Unsafe.As<byte, IntPtr>(ref byref), type); | |||
| } | |||
| else if ((_returnTransform & Transform.FunctionPointer) != 0) | |||
There was a problem hiding this comment.
Without this change, a checked build would throw in the else statement below where it tried to box _returnType.
Also verified locally with both release and checked runtime build. Did update #90376 based on CI failures. Other failures appear unrelated. |
ghost
locked as resolved and limited conversation to collaborators
Addresses the main issue of #85028 which is the inability to invoke a method that has a function pointer type argument for CoreClr. Also adds support to Mono and fixes issue in NativeAot with returning function pointer types.