Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0-rc1] [mono][ios] Revert LLVM mode for apple mobile tests #90624

Merged
merged 2 commits into from
Aug 16, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 15, 2023

PR: #90586

Description

Backport of #90586 to release/8.0-rc1

This PR reverts the default setting of using Mono AOT LLVM compilation for Apple mobile tests. The regression was introduced in #87773 which refactored a CI pipeline. The expected behavior was to AOT compile runtime and functional tests using Mono AOT LLVM runtime, but instead, Mono AOT mini runtime is used.

The fix for this issue includes passing MonoEnableLLVM property.

Customer Impact

The issue was discovered by a team member.

Testing

Manual testing and an automated testing on the CI were performed, ensuring that the Mono AOT LLVM runtime is used. The issue has been reproduced locally, and has been fixed.

Risk

Low risk. This change involves passing an additional parameter when executing runtime and functional tests on Apple mobile platforms.

IMPORTANT: If this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

The change doesn't affect code that ships in a NuGet package.

@kotlarmilos kotlarmilos self-assigned this Aug 15, 2023
@kotlarmilos kotlarmilos added Servicing-consider Issue for next servicing release review area-Infrastructure-mono os-ios Apple iOS labels Aug 15, 2023
@kotlarmilos kotlarmilos added this to the 8.0.0 milestone Aug 15, 2023
@kotlarmilos kotlarmilos requested review from steveisok, kotlarmilos, ivanpovazan and SamMonoRT and removed request for kotlarmilos August 15, 2023 18:46
@ghost
Copy link

ghost commented Aug 15, 2023

Tagging subscribers to 'os-ios': @steveisok, @akoeplinger, @kotlarmilos
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #90586 to release/8.0-rc1

/cc @kotlarmilos

Customer Impact

Testing

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: kotlarmilos
Labels:

Servicing-consider, area-Infrastructure-mono, os-ios

Milestone: -

@ghost
Copy link

ghost commented Aug 15, 2023

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #90586 to release/8.0-rc1

/cc @kotlarmilos

Customer Impact

Testing

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: kotlarmilos
Labels:

Servicing-consider, area-Infrastructure-mono

Milestone: -

@steveisok
Copy link
Member

@carlossanlop this is an infra change that impacts the test build.

@carlossanlop carlossanlop added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Aug 15, 2023
@carlossanlop carlossanlop merged commit 94f0a71 into release/8.0-rc1 Aug 16, 2023
170 of 179 checks passed
@carlossanlop carlossanlop deleted the backport/pr-90586-to-release/8.0-rc1 branch August 16, 2023 01:24
@ghost ghost locked as resolved and limited conversation to collaborators Sep 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure-mono os-ios Apple iOS Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants