-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/8.0] Limit language version on Logger and Options source gens #90709
Conversation
Tagging subscribers to this area: @dotnet/area-meta Issue DetailsBackport of #90654 to release/8.0 /cc @tarekgh Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
Tagging subscribers to this area: @dotnet/area-extensions-logging Issue DetailsBackport of #90654 to release/8.0 /cc @tarekgh Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
Thanks @eiriktsarpalis for merging the message update. can you approve this PR too? |
@ericstj can we get your autograph if you approve? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved. We need to get localization set up in this branch so that these strings can get translated before we release.
Backport of #90654 to release/8.0
/cc @tarekgh
Customer Impact
Users utilizing the Logging or Options Validation source generators in conjunction with C# compiler versions preceding 8.0 will encounter compilation errors within the generated code. This stems from our utilization of the nullability feature during code generation, which was initially supported by the compiler starting from version 8.0. As a result of this modification, the source generator will now provide a distinct diagnostic message, indicating that users must use compiler versions 8.0 and beyond.
Testing
Regression tests and adding more tests to tests the new behavior.
Risk
Very low. We are touching only the scenario which is broken and had bad user experience. This change shouldn't affect any other cases.
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging
, notrelease/X.0
.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.