[release/8.0] Skip duplicate --info output if it is known SDK output #92013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.github.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: Vitek Karas <10670590+vitek-karas@users.noreply.github.com>
|
Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov Issue DetailsBackport of #91900 to release/8.0 /cc @elinor-fung Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
jeffschwMSFT
approved these changes
Sep 13, 2023
vitek-karas
approved these changes
Sep 13, 2023
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #91900 to release/8.0
/cc @elinor-fung
Customer Impact
When the SDK is installed,
dotnet --infoincludes duplicate output. This is confusing and can also break scripts currently looking at the output. See dotnet/sdk#35237This change removes that duplicate output.
Testing
Manual validation. Automated tests added.
Risk
Very low.
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.