Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JIT: Reimport full spill clique for I_IMPL<->BYREF mismatches #92307

Merged

Commits on Sep 19, 2023

  1. JIT: Make a quirk in block morphing more explicit

    Block morphing would create oddly typed trees (mixing up
    TYP_BYREF/TYP_I_IMPL, e.g. creating LCL_VAR<I_IMPL> for a TYP_BYREF
    typed local). The only effect of this was that it would avoid some
    constant propagation. Make this more explicit by setting GTF_DONT_CSE
    instead.
    jakobbotsch committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    dba366d View commit details
    Browse the repository at this point in the history
  2. JIT: Reimport full spill clique for I_IMPL<->BYREF mismatches

    When the JIT sees code that pushes an untracked pointer from one branch,
    and a tracked pointer from another, it will reimport successors that
    were already imported under the wrong assumption of an untracked
    pointer. However, like in the other cases of spill clique handling, it
    should reimport the entire spill clique, including predecssors and other
    successors of those; otherwise we can still end up with mistyped LCL_VAR
    nodes.
    jakobbotsch committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    d3c831c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e4dd78a View commit details
    Browse the repository at this point in the history
  4. A bit more

    jakobbotsch committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    49f5d6b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    f6a3668 View commit details
    Browse the repository at this point in the history
  6. Fix build

    jakobbotsch committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    5d4c120 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2023

  1. Merge branch 'main' of github.com:dotnet/runtime into lcl-type-mismat…

    …ch-reimport-spill-clique
    jakobbotsch committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    3121513 View commit details
    Browse the repository at this point in the history