[release/8.0-rc2] JIT: Fix invalid containment of vector broadcasts #92371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.github.com/in/15368?s=60&v=4){kind=small}
The containment checks for vector broadcasts were missing a size check, meaning that a uint broadcast could contain a ubyte/ushort indirection. That would lead to out-of-bounds reads. Fix #83387
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsBackport of #92333 to release/8.0-rc2 /cc @jakobbotsch Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
|
The issue here might be related to #92357, so I am waiting a bit to continue with this backport until we figure out exactly how they relate. Edit: nope, that issue seems related to embedded broadcasts instead. |
jeffschwMSFT
approved these changes
Sep 21, 2023
tannergooding
approved these changes
Sep 21, 2023
jeffschwMSFT
added
Servicing-approved
Closed
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #92333 to release/8.0-rc2
/cc @jakobbotsch
Customer Impact
The JIT may generate bad code for
VectorXYZ<T>.Create(x)wherexis a memory location of smaller size thanT. In that case the JIT may incorrectly read the memory location using the larger typeT.For example,
Vector128<int>.Create(x.ShortField)may generate bad code reading 4 bytes fromShortFieldinstead of just 2. Customer reported in #83387.Testing
Regression test included.
Risk
Low, disables the JIT's containment optimization in the affected cases.