-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDK 2.1.500 fails to set IsTestProject in net40 projects #2690
Comments
jnm2
added a commit
to jnm2/nunit3-vs-adapter
that referenced
this issue
Nov 22, 2018
jnm2
added a commit
to jnm2/nunit3-vs-adapter
that referenced
this issue
Nov 22, 2018
This was referenced Nov 23, 2018
This issue was moved to microsoft/vstest#1850 |
wli3
pushed a commit
that referenced
this issue
Feb 7, 2020
…906.10 (#2690) - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19456.10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Here's a full repro: DotnetTestBug.zip
Projects like this worked in all SDKs up to 2.1.500 because Microsoft.NET.Test.Sdk sets
<IsTestProject>true</IsTestProject>
:E.g. using SDK 2.1.403, you get this output for
dotnet test
:Starting with SDK 2.1.500,
<IsTestProject>true</IsTestProject>
is no longer set.dotnet test
gives:Note that the same
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="15.9.0" />
is used in both cases.Wasn't sure if this belonged here or at https://github.com/Microsoft/vstest/issues.
Issues
Is it your intention to require test projects which include a
net40
target to have to manually include<IsTestProject>true</IsTestProject>
directly in the test csproj? Why isn't this the case fornet45
, since VSTest 15.9 supportsnet40
andnet45
equally?This is invalid XML. Second tag should be a closing tag: <IsTestProject>true</IsTestProject>
The text was updated successfully, but these errors were encountered: